From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B134BC38A24 for ; Thu, 7 May 2020 07:24:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8BF4720753 for ; Thu, 7 May 2020 07:24:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725819AbgEGHYU (ORCPT ); Thu, 7 May 2020 03:24:20 -0400 Received: from mga18.intel.com ([134.134.136.126]:49708 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725809AbgEGHYU (ORCPT ); Thu, 7 May 2020 03:24:20 -0400 IronPort-SDR: SrHE1OjEBk5Cq6XpPlvGbBPHqAyaycjBVyR1OE7mgzcEoE6E3mnKH1HLNQ2sEAQR6Fh/o1RKbb Z7hYL28bz5Rg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 May 2020 00:24:19 -0700 IronPort-SDR: waf4mIazFQxt3LHU1hcNng7o3oXZj9BZRbPP5nO6+FhDEAuBSPZRNALAIhCb3CpN4YM6TalFjO 9vxzbw4OfmKQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,362,1583222400"; d="scan'208";a="370030154" Received: from mstoisox-wtg9.ger.corp.intel.com (HELO [10.252.41.26]) ([10.252.41.26]) by fmsmga001.fm.intel.com with ESMTP; 07 May 2020 00:24:18 -0700 Subject: Re: -EBUSY with some selftests on 5.7-rcX To: Andrii Nakryiko Cc: bpf References: <2408eda9-b001-3c34-d037-f7b5762bf7d7@linux.intel.com> From: Mikko Ylinen Message-ID: Date: Thu, 7 May 2020 10:24:14 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On 06/05/2020 23:18, Andrii Nakryiko wrote: > On Wed, May 6, 2020 at 12:28 PM Mikko Ylinen > wrote: >> The error seems to come from register_fentry() but I don't yet have >> good logs what goes wrong. > > Ok, this is actually useful. It's still few possibilities, but most > seem to be related to ftrace subsystem. So here's portion of my > Kconfig with FTRACE settings, see if you have some of those disabled > and try to enable them, it might help. For instance, if you don't have > a 5-byte preample in kernel functions (not sure which setting turns > this on), bpf_arch_text_poke would also return EBUSY. Some of > ftrace-specific code returns EBUSY in multiple places as well. So I'd > start with trying to enable a lot of FTRACE stuff first: With the following config changes: -# CONFIG_FUNCTION_TRACER is not set +CONFIG_FUNCTION_TRACER=y +CONFIG_FUNCTION_GRAPH_TRACER=y +CONFIG_DYNAMIC_FTRACE=y +CONFIG_DYNAMIC_FTRACE_WITH_REGS=y +CONFIG_DYNAMIC_FTRACE_WITH_DIRECT_CALLS=y +# CONFIG_FUNCTION_PROFILER is not set # ./test_progs -t fentry_fexit #13 fentry_fexit:OK Summary: 1/0 PASSED, 0 SKIPPED, 0 FAILED # ./test_progs -t test_lsm #70 test_lsm:OK Summary: 1/0 PASSED, 0 SKIPPED, 0 FAILED Thanks! Perhaps there could be a check whether the operation is supported and if not,-ENOTSUPP is returned? -- Mikko