bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Quentin Monnet <quentin@isovalent.com>
To: Carlos Neira <cneirabustos@gmail.com>, netdev@vger.kernel.org
Cc: yhs@fb.com, ebiederm@xmission.com, brouer@redhat.com,
Subject: Re: [PATCH bpf-next] bpf_helpers_doc.py: Fix warning when compiling bpftool.
Date: Fri, 13 Mar 2020 16:20:03 +0000	[thread overview]
Message-ID: <a71d42ca-662d-d057-6939-60ad2bc44e1d@isovalent.com> (raw)
In-Reply-To: <20200313154650.13366-1-cneirabustos@gmail.com>

2020-03-13 12:46 UTC-0300 ~ Carlos Neira <cneirabustos@gmail.com>
> When compiling bpftool the following warning is found: 
> "declaration of 'struct bpf_pidns_info' will not be visible outside of this function."
> This patch adds struct bpf_pidns_info to type_fwds array to fix this.
> Signed-off-by: Carlos Neira <cneirabustos@gmail.com>
> ---
>  scripts/bpf_helpers_doc.py | 1 +
>  1 file changed, 1 insertion(+)
> diff --git a/scripts/bpf_helpers_doc.py b/scripts/bpf_helpers_doc.py
> index c1e2b5410faa..f43d193aff3a 100755
> --- a/scripts/bpf_helpers_doc.py
> +++ b/scripts/bpf_helpers_doc.py
> @@ -400,6 +400,7 @@ class PrinterHelpers(Printer):
>              'struct bpf_fib_lookup',
>              'struct bpf_perf_event_data',
>              'struct bpf_perf_event_value',
> +            'struct bpf_pidns_info',
>              'struct bpf_sock',
>              'struct bpf_sock_addr',
>              'struct bpf_sock_ops',

Note that the warning is not specific to bpftool (I just happened to
spot it when compiling this tool), it's for anything that uses libbpf,
or more generally, the generated header for helpers.

It is fixed by your patch, thank you!

Reviewed-by: Quentin Monnet <quentin@isovalent.com>

  reply	other threads:[~2020-03-13 16:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-13 15:46 [PATCH bpf-next] bpf_helpers_doc.py: Fix warning when compiling bpftool Carlos Neira
2020-03-13 16:20 ` Quentin Monnet [this message]
2020-03-13 17:21 ` Martin KaFai Lau
2020-03-13 18:23   ` Carlos Antonio Neira Bustos
2020-03-13 20:13     ` Daniel Borkmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a71d42ca-662d-d057-6939-60ad2bc44e1d@isovalent.com \
    --to=quentin@isovalent.com \
    --cc=bpf@vger.kernel.org \
    --cc=brouer@redhat.com \
    --cc=cneirabustos@gmail.com \
    --cc=ebiederm@xmission.com \
    --cc=netdev@vger.kernel.org \
    --cc=yhs@fb.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).