From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58EBCC10DCE for ; Fri, 13 Mar 2020 16:20:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 26B762072C for ; Fri, 13 Mar 2020 16:20:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=isovalent-com.20150623.gappssmtp.com header.i=@isovalent-com.20150623.gappssmtp.com header.b="B7sB/m8Q" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726461AbgCMQUH (ORCPT ); Fri, 13 Mar 2020 12:20:07 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:40767 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726676AbgCMQUH (ORCPT ); Fri, 13 Mar 2020 12:20:07 -0400 Received: by mail-wr1-f67.google.com with SMTP id f3so5855050wrw.7 for ; Fri, 13 Mar 2020 09:20:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=isovalent-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=9yAuat/22fNvrLQHtVwJOuXJKdfyxNZNaC4y6TiV+Rc=; b=B7sB/m8QnCzsW/O5BFA6AjN8CaY3UzbWxEwN/khlowudBy/e7Jhtto+AE6YEiV8VdN WMBJdvfJdLw0/ydX6n6/OKFUivmhJYwT8GRm+xmE7Zd0Krt4rCGiaGG1sDegoUUpdczD L7DFoiVkSPIbhhZp78YPE/1yUzFaWLm1v9lGpZMYpwmN2smyhfX7dBeTnzICqQMNVuz+ 84+j445iQ6+s4j6jnnEvlaMxMSK5o5VP8+6TAuJlZsbN7OFfPkrg/iUPmeZMg05Sj5Xs wLmxO2PURtw2J2Z3Td3szH6avZEBAhUVPJ0Wh3Ifb05VipUFIxsK0JCAzKJ1Ouworuqs AjbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=9yAuat/22fNvrLQHtVwJOuXJKdfyxNZNaC4y6TiV+Rc=; b=QE3knUwHzHiscXPFYdMcSZg1pKsrbGqjaIw29foiUJVgrMSVD7SAfolm0BMQKGe1Iu 60GsK4BIgaCbziG3EKRu85jnA5MSL0/lXHo4uhBoIVgbfJk4g0h2+/mK51s72Oe3EMtt aqBVfb/i6Ltf8REoF71nikaqRvQNsjRS1rB6nN4OZDXpmU0FsnOwEgMAziBWoCNNxoHU /h6w5PEnUVnU7GM7emA/Hx9XB+9QAtuRPFKeZmUjJyogMPwfaHZqC2Ln2HYg3mC24oWj IrILwFxjwYwVO64elePm6LrYpeF6d9W8jFubW97Kil/8u2KqjyC2QkwWbFRvwgWFgSYm kAsg== X-Gm-Message-State: ANhLgQ3C2VN7MAaQ9J/KF+K5L/xIh87VG9FkTZxpGuuQIDOHwd4bdXHg VOkdDQcXVtB0OjIrk9fhSdePj/TQ25M= X-Google-Smtp-Source: ADFU+vvW95OwsBswiJRiJS7hwm11qgjSosIqo5QDvCnw+u5d9QvIUy45j2V1wA/ZZj+Q3PmRIx//aw== X-Received: by 2002:adf:f847:: with SMTP id d7mr17807816wrq.31.1584116404760; Fri, 13 Mar 2020 09:20:04 -0700 (PDT) Received: from [192.168.1.10] ([194.35.118.102]) by smtp.gmail.com with ESMTPSA id n1sm35833275wrj.77.2020.03.13.09.20.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Mar 2020 09:20:04 -0700 (PDT) Subject: Re: [PATCH bpf-next] bpf_helpers_doc.py: Fix warning when compiling bpftool. To: Carlos Neira , netdev@vger.kernel.org Cc: yhs@fb.com, ebiederm@xmission.com, brouer@redhat.com, bpf@vger.kernel.org References: <20200313154650.13366-1-cneirabustos@gmail.com> From: Quentin Monnet Message-ID: Date: Fri, 13 Mar 2020 16:20:03 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200313154650.13366-1-cneirabustos@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org 2020-03-13 12:46 UTC-0300 ~ Carlos Neira > > When compiling bpftool the following warning is found: > "declaration of 'struct bpf_pidns_info' will not be visible outside of this function." > This patch adds struct bpf_pidns_info to type_fwds array to fix this. > > Signed-off-by: Carlos Neira > --- > scripts/bpf_helpers_doc.py | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/scripts/bpf_helpers_doc.py b/scripts/bpf_helpers_doc.py > index c1e2b5410faa..f43d193aff3a 100755 > --- a/scripts/bpf_helpers_doc.py > +++ b/scripts/bpf_helpers_doc.py > @@ -400,6 +400,7 @@ class PrinterHelpers(Printer): > 'struct bpf_fib_lookup', > 'struct bpf_perf_event_data', > 'struct bpf_perf_event_value', > + 'struct bpf_pidns_info', > 'struct bpf_sock', > 'struct bpf_sock_addr', > 'struct bpf_sock_ops', > Note that the warning is not specific to bpftool (I just happened to spot it when compiling this tool), it's for anything that uses libbpf, or more generally, the generated header for helpers. It is fixed by your patch, thank you! Reviewed-by: Quentin Monnet