From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9F2BC761A6 for ; Thu, 30 Mar 2023 17:36:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232409AbjC3RgF (ORCPT ); Thu, 30 Mar 2023 13:36:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231867AbjC3RgF (ORCPT ); Thu, 30 Mar 2023 13:36:05 -0400 Received: from out-15.mta0.migadu.com (out-15.mta0.migadu.com [91.218.175.15]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DDDA5FD9 for ; Thu, 30 Mar 2023 10:36:04 -0700 (PDT) Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1680197762; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FQpmT7tbl2QUNk3CUqjQMUsxWt9no5L8ZIkxUE4+ZQA=; b=fVzfBRJ+hXGUSSpj0k7vuHOzyPLY7eNgiH68DMpaJmECmDIl2Ehzp69QSVWwW5EVZbAxAg pkmWUXDz3TnuC4MBsfNftZtX3IQFkVf/uRtZKj8HD+fQHXZ9McWrVtsSKdkPZcxhbQqwCp U88wwy8fP9F/HMbGCwO9ULXMF8yvCHs= Date: Thu, 30 Mar 2023 10:35:59 -0700 MIME-Version: 1.0 Subject: Re: [PATCH v5 bpf-next 2/7] udp: seq_file: Remove bpf_seq_afinfo from udp_iter_state Content-Language: en-US To: Aditi Ghag Cc: sdf@google.com, edumazet@google.com, Martin KaFai Lau , bpf@vger.kernel.org References: <20230330151758.531170-1-aditi.ghag@isovalent.com> <20230330151758.531170-3-aditi.ghag@isovalent.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Martin KaFai Lau In-Reply-To: <20230330151758.531170-3-aditi.ghag@isovalent.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On 3/30/23 8:17 AM, Aditi Ghag wrote: > This is a preparatory commit to remove the field. The field was > previously shared between proc fs and BPF UDP socket iterators. As the > follow-up commits will decouple the implementation for the iterators, > remove the field. As for BPF socket iterator, filtering of sockets is > exepected to be done in BPF programs. > > Suggested-by: Martin KaFai Lau > Signed-off-by: Aditi Ghag > --- > include/net/udp.h | 1 - > net/ipv4/udp.c | 15 +++------------ > 2 files changed, 3 insertions(+), 13 deletions(-) > > diff --git a/include/net/udp.h b/include/net/udp.h > index de4b528522bb..5cad44318d71 100644 > --- a/include/net/udp.h > +++ b/include/net/udp.h > @@ -437,7 +437,6 @@ struct udp_seq_afinfo { > struct udp_iter_state { > struct seq_net_private p; > int bucket; > - struct udp_seq_afinfo *bpf_seq_afinfo; This patch does not compile because the remaining st->bpf_seq_afinfo usages are only removed in a later patch 4. https://patchwork.hopto.org/static/nipa/735459/13194325/build_clang/stderr Mostly a heads up. No need to re-spin now. Review can be continued on this revision.