From: Paul Walmsley <paul.walmsley@sifive.com>
To: Kees Cook <keescook@chromium.org>, Tycho Andersen <tycho@tycho.ws>
Cc: David Abdurachmanov <david.abdurachmanov@gmail.com>,
Palmer Dabbelt <palmer@sifive.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Oleg Nesterov <oleg@redhat.com>,
Andy Lutomirski <luto@amacapital.net>,
Will Drewry <wad@chromium.org>, Shuah Khan <shuah@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>,
David Abdurachmanov <david.abdurachmanov@sifive.com>,
Thomas Gleixner <tglx@linutronix.de>,
Allison Randal <allison@lohutok.net>,
Alexios Zavras <alexios.zavras@intel.com>,
Anup Patel <Anup.Patel@wdc.com>,
Vincent Chen <vincentc@andestech.com>,
Alan Kao <alankao@andestech.com>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, netdev@vger.kernel.org,
bpf@vger.kernel.org, me@carlosedp.com
Subject: Re: [PATCH v2] riscv: add support for SECCOMP and SECCOMP_FILTER
Date: Wed, 28 Aug 2019 18:30:14 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.9999.1908281825240.13811@viisi.sifive.com> (raw)
In-Reply-To: <201908261043.08510F5E66@keescook>
Hi Kees,
On Mon, 26 Aug 2019, Kees Cook wrote:
> On Mon, Aug 26, 2019 at 09:39:50AM -0700, David Abdurachmanov wrote:
> > I don't have the a build with SECCOMP for the board right now, so it
> > will have to wait. I just finished a new kernel (almost rc6) for Fedora,
>
> FWIW, I don't think this should block landing the code: all the tests
> fail without seccomp support. ;) So this patch is an improvement!
Am sympathetic to this -- we did it with the hugetlb patches for RISC-V --
but it would be good to understand a little bit more about why the test
fails before we merge it.
Once we merge the patch, it will probably reduce the motivation for others
to either understand and fix the underlying problem with the RISC-V code
-- or, if it truly is a flaky test, to drop (or fix) the test in the
seccomp_bpf kselftests.
Thanks for helping to take a closer look at this,
- Paul
next prev parent reply other threads:[~2019-08-29 1:30 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 20:55 [PATCH v2] riscv: add support for SECCOMP and SECCOMP_FILTER David Abdurachmanov
2019-08-23 22:54 ` Carlos Eduardo de Paula
2019-08-23 23:01 ` Carlos Eduardo de Paula
2019-08-24 0:30 ` Paul Walmsley
2019-08-24 1:04 ` David Abdurachmanov
2019-08-24 1:10 ` David Abdurachmanov
2019-08-24 1:18 ` Paul Walmsley
2019-08-25 21:51 ` Kees Cook
2019-08-28 21:39 ` David Abdurachmanov
2019-08-26 14:57 ` Tycho Andersen
2019-08-26 16:39 ` David Abdurachmanov
2019-08-26 17:48 ` Kees Cook
2019-08-29 1:30 ` Paul Walmsley [this message]
2019-09-27 17:20 ` Kees Cook
2019-10-05 1:24 ` Paul Walmsley
2019-08-25 21:59 ` Kees Cook
2019-08-28 17:52 ` Andy Lutomirski
2019-08-28 18:01 ` Kees Cook
2019-09-03 22:27 ` Palmer Dabbelt
2019-09-27 20:58 ` Andy Lutomirski
2019-10-06 19:18 ` Andy Lutomirski
2019-08-28 21:37 ` David Abdurachmanov
2019-08-28 23:44 ` Kees Cook
2019-10-05 1:20 ` Paul Walmsley
2019-10-14 21:06 ` Paul Walmsley
2019-10-15 16:27 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.9999.1908281825240.13811@viisi.sifive.com \
--to=paul.walmsley@sifive.com \
--cc=Anup.Patel@wdc.com \
--cc=alankao@andestech.com \
--cc=alexios.zavras@intel.com \
--cc=allison@lohutok.net \
--cc=aou@eecs.berkeley.edu \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=david.abdurachmanov@gmail.com \
--cc=david.abdurachmanov@sifive.com \
--cc=kafai@fb.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=luto@amacapital.net \
--cc=me@carlosedp.com \
--cc=netdev@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=palmer@sifive.com \
--cc=shuah@kernel.org \
--cc=songliubraving@fb.com \
--cc=tglx@linutronix.de \
--cc=tycho@tycho.ws \
--cc=vincentc@andestech.com \
--cc=wad@chromium.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).