From: Jules Irenge <jbi.octave@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Jules Irenge <jbi.octave@gmail.com>,
boqun.feng@gmail.com, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org, netdev@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH 2/8] raw: Add missing annotations to raw_seq_start() and raw_seq_stop()
Date: Wed, 11 Mar 2020 01:40:46 +0000 (GMT) [thread overview]
Message-ID: <alpine.LFD.2.21.2003110138120.3619@ninjahub.org> (raw)
In-Reply-To: <af9016d1-c224-ea61-3290-330ed0fe8d60@gmail.com>
On Tue, 10 Mar 2020, Eric Dumazet wrote:
>
>
> On 3/10/20 6:09 PM, Jules Irenge wrote:
> > Sparse reports warnings at raw_seq_start() and raw_seq_stop()
> >
> > warning: context imbalance in raw_seq_start() - wrong count at exit
> > warning: context imbalance in raw_seq_stop() - unexpected unlock
> >
> > The root cause is the missing annotations at raw_seq_start()
> > and raw_seq_stop()
> > Add the missing __acquires(&h->lock) annotation
> > Add the missing __releases(&h->lock) annotation
> >
> > Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> > ---
> > net/ipv4/raw.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/net/ipv4/raw.c b/net/ipv4/raw.c
> > index 3183413ebc6c..47665919048f 100644
> > --- a/net/ipv4/raw.c
> > +++ b/net/ipv4/raw.c
> > @@ -1034,6 +1034,7 @@ static struct sock *raw_get_idx(struct seq_file *seq, loff_t pos)
> > }
> >
> > void *raw_seq_start(struct seq_file *seq, loff_t *pos)
> > + __acquires(&h->lock)
>
> I dunno, h variable is not yet defined/declared at this point,
> this looks weird.
>
> > {
> > struct raw_hashinfo *h = PDE_DATA(file_inode(seq->file));
> >
> > @@ -1056,6 +1057,7 @@ void *raw_seq_next(struct seq_file *seq, void *v, loff_t *pos)
> > EXPORT_SYMBOL_GPL(raw_seq_next);
> >
> > void raw_seq_stop(struct seq_file *seq, void *v)
> > + __releases(&h->lock)
> > {
> > struct raw_hashinfo *h = PDE_DATA(file_inode(seq->file));
> >
> >
>
Thanks for the feedback,
I think h is a pointer of type struct raw_hashinfo, in which member lock
is initialized on line number 89.
Kind regards
next prev parent reply other threads:[~2020-03-11 1:40 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0/8>
2020-03-11 1:09 ` [PATCH 0/8] Lock warning cleanups Jules Irenge
2020-03-11 1:09 ` [PATCH 1/8] bpf: Add missing annotations for __bpf_prog_enter() and __bpf_prog_exit() Jules Irenge
2020-03-13 19:49 ` Daniel Borkmann
2020-03-11 1:09 ` [PATCH 2/8] raw: Add missing annotations to raw_seq_start() and raw_seq_stop() Jules Irenge
2020-03-11 1:15 ` Eric Dumazet
2020-03-11 1:40 ` Jules Irenge [this message]
2020-03-12 6:20 ` David Miller
2020-03-11 1:09 ` [PATCH 3/8] tcp: Add missing annotation for tcp_child_process() Jules Irenge
2020-03-11 1:14 ` Eric Dumazet
2020-03-11 1:28 ` Jules Irenge
2020-03-12 6:20 ` David Miller
2020-03-11 1:09 ` [PATCH 4/8] netfilter: Add missing annotation for ctnetlink_parse_nat_setup() Jules Irenge
2020-03-27 17:22 ` Pablo Neira Ayuso
2020-03-11 1:09 ` [PATCH 5/8] netfilter: conntrack: Add missing annotations for nf_conntrack_all_lock() and nf_conntrack_all_unlock() Jules Irenge
2020-03-27 17:22 ` Pablo Neira Ayuso
2020-03-11 1:09 ` [PATCH 6/8] net: Add missing annotation for *netlink_seq_start() Jules Irenge
2020-03-12 6:20 ` David Miller
2020-03-11 1:09 ` [PATCH 7/8] ALSA: firewire-tascam: Add missing annotation for tscm_hwdep_read_queue() Jules Irenge
2020-03-11 3:19 ` Takashi Sakamoto
2020-03-11 6:56 ` Takashi Iwai
2020-03-11 1:09 ` [PATCH 8/8] ALSA: firewire-tascam: Add missing annotation for tscm_hwdep_read_locked() Jules Irenge
2020-03-11 3:18 ` Takashi Sakamoto
2020-03-11 6:56 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.21.2003110138120.3619@ninjahub.org \
--to=jbi.octave@gmail.com \
--cc=boqun.feng@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).