From: Eric Dumazet <eric.dumazet@gmail.com>
To: "Björn Töpel" <bjorn.topel@intel.com>,
"Eric Dumazet" <eric.dumazet@gmail.com>,
"Björn Töpel" <bjorn.topel@gmail.com>,
ast@kernel.org, daniel@iogearbox.net, netdev@vger.kernel.org,
bpf@vger.kernel.org
Cc: magnus.karlsson@intel.com, kuba@kernel.org,
intel-wired-lan@lists.osuosl.org
Subject: Re: [PATCH bpf-next 4/4] ixgbe, xsk: use XSK_NAPI_WEIGHT as NAPI poll budget
Date: Tue, 8 Sep 2020 17:12:10 +0200 [thread overview]
Message-ID: <b17dcc6e-cb48-9c90-f233-a178b23f9004@gmail.com> (raw)
In-Reply-To: <c5dac6d2-e2aa-05a4-2606-7db0687dd12b@intel.com>
On 9/8/20 1:49 PM, Björn Töpel wrote:
> On 2020-09-08 11:45, Eric Dumazet wrote:
>>
>>
>> On 9/7/20 5:02 PM, Björn Töpel wrote:
>>> From: Björn Töpel <bjorn.topel@intel.com>
>>>
>>> Start using XSK_NAPI_WEIGHT as NAPI poll budget for the AF_XDP Rx
>>> zero-copy path.
>>>
>>> Signed-off-by: Björn Töpel <bjorn.topel@intel.com>
>>> ---
>>> drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c
>>> index 3771857cf887..f32c1ba0d237 100644
>>> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c
>>> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c
>>> @@ -239,7 +239,7 @@ int ixgbe_clean_rx_irq_zc(struct ixgbe_q_vector *q_vector,
>>> bool failure = false;
>>> struct sk_buff *skb;
>>> - while (likely(total_rx_packets < budget)) {
>>> + while (likely(total_rx_packets < XSK_NAPI_WEIGHT)) {
>>> union ixgbe_adv_rx_desc *rx_desc;
>>> struct ixgbe_rx_buffer *bi;
>>> unsigned int size
>>
>> This is a violation of NAPI API. IXGBE is already diverging a bit from best practices.
>>
>
> Thanks for having a look, Eric! By diverging from best practices, do
> you mean that multiple queues share one NAPI context, and the budget
> is split over the queues (say, 4 queues, 64/4 per queue), or that Tx
> simply ignores the budget? Or both?
For instance, having ixgbe_poll() doing :
return min(work_done, budget - 1);
is quite interesting. It could hide bugs like :
I got a budget of 4, and processed 9999 packets because my maths have a bug,
but make sure to pretend we processed 3 packets...
>
>> There are reasons we want to control the budget from callers,
>> if you want bigger budget just increase it instead of using your own ?
>>
>> I would rather use a generic patch.
>>
>
> Hmm, so a configurable NAPI budget for, say, the AF_XDP enabled
> queues/NAPIs? Am I reading that correct? (Note that this is *only* for
> the AF_XDP enabled queues.)
>
> I'll try to rework this to something more palatable.
>
>
> Thanks,
> Björn
>
>
next prev parent reply other threads:[~2020-09-08 20:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 15:02 [PATCH bpf-next 0/4] xsk: increase NAPI budget for AF_XDP zero-copy path Björn Töpel
2020-09-07 15:02 ` [PATCH bpf-next 1/4] xsk: add XSK_NAPI_WEIGHT define Björn Töpel
2020-09-07 15:02 ` [PATCH bpf-next 2/4] i40e, xsk: use XSK_NAPI_WEIGHT as NAPI poll budget Björn Töpel
2020-09-07 15:02 ` [PATCH bpf-next 3/4] ice, " Björn Töpel
2020-09-07 15:02 ` [PATCH bpf-next 4/4] ixgbe, " Björn Töpel
2020-09-07 19:32 ` Jakub Kicinski
2020-09-08 5:38 ` Björn Töpel
2020-09-08 9:45 ` Eric Dumazet
2020-09-08 11:49 ` Björn Töpel
2020-09-08 15:12 ` Eric Dumazet [this message]
2020-09-08 10:12 ` [Intel-wired-lan] " Paul Menzel
2020-09-08 11:12 ` Björn Töpel
2020-09-08 11:20 ` Paul Menzel
2020-09-08 11:43 ` Björn Töpel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b17dcc6e-cb48-9c90-f233-a178b23f9004@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=ast@kernel.org \
--cc=bjorn.topel@gmail.com \
--cc=bjorn.topel@intel.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).