From: Daniel Borkmann <daniel@iogearbox.net>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: Yan Zhu <zhuyan34@huawei.com>,
andrii@kernel.org, ast@kernel.org, bpf@vger.kernel.org,
john.fastabend@gmail.com, kafai@fb.com, keescook@chromium.org,
kpsingh@kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, liucheng32@huawei.com,
netdev@vger.kernel.org, nixiaoming@huawei.com,
songliubraving@fb.com, xiechengliang1@huawei.com, yhs@fb.com,
yzaikin@google.com, zengweilin@huawei.com, leeyou.li@huawei.com,
laiyuanyuan.lai@huawei.com
Subject: Re: [PATCH v4 sysctl-next] bpf: move bpf sysctls from kernel/sysctl.c to bpf module
Date: Wed, 13 Apr 2022 21:40:58 +0200 [thread overview]
Message-ID: <b615bd44-6bd1-a958-7e3f-dd2ff58931a1@iogearbox.net> (raw)
In-Reply-To: <Ylcd0zvHhi96zVi+@bombadil.infradead.org>
On 4/13/22 9:00 PM, Luis Chamberlain wrote:
> On Wed, Apr 13, 2022 at 04:45:00PM +0200, Daniel Borkmann wrote:
>> On 4/7/22 9:07 AM, Yan Zhu wrote:
>>> We're moving sysctls out of kernel/sysctl.c as its a mess. We
>>> already moved all filesystem sysctls out. And with time the goal is
>>> to move all sysctls out to their own subsystem/actual user.
>>>
>>> kernel/sysctl.c has grown to an insane mess and its easy to run
>>> into conflicts with it. The effort to move them out is part of this.
>>>
>>> Signed-off-by: Yan Zhu <zhuyan34@huawei.com>
>>
>> Acked-by: Daniel Borkmann <daniel@iogearbox.net>
>>
>> Given the desire is to route this via sysctl-next and we're not shortly
>> before but after the merge win, could we get a feature branch for bpf-next
>> to pull from to avoid conflicts with ongoing development cycle?
>
> Sure thing. So I've never done this sort of thing, so forgive me for
> being new at it. Would it make sense to merge this change to sysctl-next
> as-is today and put a frozen branch sysclt-next-bpf to reflect this,
> which bpf-next can merge. And then sysctl-next just continues to chug on
> its own? As-is my goal is to keep sysctl-next as immutable as well.
>
> Or is there a better approach you can recommend?
Are you able to merge the pr/bpf-sysctl branch into your sysctl-next tree?
https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git/log/?h=pr/bpf-sysctl
This is based off common base for both trees (3123109284176b1532874591f7c81f3837bbdc17)
so should only pull in the single commit then.
Thanks,
Daniel
next prev parent reply other threads:[~2022-04-13 19:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 1:35 [PATCH] bpf: move the bpf syscall sysctl table to its own module Yan Zhu
2022-02-23 1:42 ` Luis Chamberlain
2022-02-23 10:28 ` [PATCH v2 sysctl-next] bpf: move the bpf syscall sysctl table to bpf module Yan Zhu
2022-02-28 15:53 ` Daniel Borkmann
2022-02-28 23:41 ` Luis Chamberlain
2022-03-02 1:58 ` Yan Zhu
2022-03-02 2:04 ` [PATCH v3 sysctl-next] bpf: move bpf sysctls from kernel/sysctl.c " Yan Zhu
2022-03-02 20:39 ` Luis Chamberlain
2022-03-03 23:44 ` Daniel Borkmann
2022-03-04 0:23 ` Luis Chamberlain
2022-04-06 22:41 ` Luis Chamberlain
2022-04-07 7:07 ` [PATCH v4 " Yan Zhu
2022-04-13 14:45 ` Daniel Borkmann
2022-04-13 19:00 ` Luis Chamberlain
2022-04-13 19:40 ` Daniel Borkmann [this message]
2022-04-13 19:46 ` Luis Chamberlain
2022-04-13 19:50 ` Daniel Borkmann
2022-02-23 4:28 ` [PATCH] bpf: move the bpf syscall sysctl table to its own module Matthew Wilcox
2022-02-23 5:06 ` Alexei Starovoitov
2022-02-23 9:50 ` Yan Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b615bd44-6bd1-a958-7e3f-dd2ff58931a1@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=keescook@chromium.org \
--cc=kpsingh@kernel.org \
--cc=laiyuanyuan.lai@huawei.com \
--cc=leeyou.li@huawei.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liucheng32@huawei.com \
--cc=mcgrof@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nixiaoming@huawei.com \
--cc=songliubraving@fb.com \
--cc=xiechengliang1@huawei.com \
--cc=yhs@fb.com \
--cc=yzaikin@google.com \
--cc=zengweilin@huawei.com \
--cc=zhuyan34@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).