From: Daniel Borkmann <daniel@iogearbox.net>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>,
Ilya Leoshkevich <iii@linux.ibm.com>
Cc: Alexei Starovoitov <ast@kernel.org>, bpf <bpf@vger.kernel.org>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>
Subject: Re: [PATCH bpf-next 3/3] libbpf: Use bpf_probe_read_kernel
Date: Tue, 28 Jul 2020 23:16:14 +0200 [thread overview]
Message-ID: <bea74a32-746c-c310-67c8-477dcd442fb3@iogearbox.net> (raw)
In-Reply-To: <CAEf4BzaSJp-fOn2MG_8Fc2mo9ji5gZBLn2xCGyCiAmPbHkqSQQ@mail.gmail.com>
On 7/28/20 9:11 PM, Andrii Nakryiko wrote:
> On Tue, Jul 28, 2020 at 5:15 AM Ilya Leoshkevich <iii@linux.ibm.com> wrote:
>>
>> Yet another adaptation to commit 0ebeea8ca8a4 ("bpf: Restrict
>> bpf_probe_read{, str}() only to archs where they work") that makes more
>> samples compile on s390.
>>
>> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
>
> Sorry, we can't do this yet. This will break on older kernels that
> don't yet have bpf_probe_read_kernel() implemented. Met and Yonghong
> are working on extending a set of CO-RE relocations, that would allow
> to do bpf_probe_read_kernel() detection on BPF side, transparently for
> an application, and will pick either bpf_probe_read() or
> bpf_probe_read_kernel(). It should be ready soon (this or next week,
> most probably), though it will have dependency on the latest Clang.
> But for now, please don't change this.
Could you elaborate what this means wrt dependency on latest clang? Given clang
releases have a rather long cadence, what about existing users with current clang
releases?
>> tools/lib/bpf/bpf_core_read.h | 51 ++++++++++++++++++-----------------
>> tools/lib/bpf/bpf_tracing.h | 15 +++++++----
>> 2 files changed, 37 insertions(+), 29 deletions(-)
>>
>
> [...]
>
next prev parent reply other threads:[~2020-07-28 21:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 12:00 [PATCH bpf-next 0/3] samples/bpf: A couple s390 fixes Ilya Leoshkevich
2020-07-28 12:00 ` [PATCH bpf-next 1/3] samples/bpf: Fix building out of srctree Ilya Leoshkevich
2020-07-28 20:48 ` Song Liu
2020-07-28 21:12 ` Ilya Leoshkevich
2020-07-28 21:37 ` Ilya Leoshkevich
2020-07-28 12:00 ` [PATCH bpf-next 2/3] samples/bpf: Fix test_map_in_map on s390 Ilya Leoshkevich
2020-07-28 20:59 ` Song Liu
2020-07-28 22:05 ` Ilya Leoshkevich
2020-07-28 12:00 ` [PATCH bpf-next 3/3] libbpf: Use bpf_probe_read_kernel Ilya Leoshkevich
2020-07-28 19:11 ` Andrii Nakryiko
2020-07-28 21:16 ` Daniel Borkmann [this message]
2020-07-29 4:06 ` Andrii Nakryiko
2020-07-29 21:01 ` Daniel Borkmann
2020-07-29 21:36 ` Andrii Nakryiko
2020-07-29 21:54 ` Daniel Borkmann
2020-07-29 22:05 ` Andrii Nakryiko
2020-07-29 22:12 ` Daniel Borkmann
2020-07-29 22:17 ` Andrii Nakryiko
2020-07-31 17:41 ` Andrii Nakryiko
2020-07-31 20:34 ` Daniel Borkmann
2020-08-05 18:32 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bea74a32-746c-c310-67c8-477dcd442fb3@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=andrii.nakryiko@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=iii@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).