From: Daniel Borkmann <daniel@iogearbox.net>
To: Yonghong Song <yhs@fb.com>, Andrii Nakryiko <andriin@fb.com>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Alexei Starovoitov <ast@fb.com>
Cc: "andrii.nakryiko@gmail.com" <andrii.nakryiko@gmail.com>,
Kernel Team <Kernel-team@fb.com>
Subject: Re: [PATCH v2 bpf-next 0/3] fix BTF verification size resolution
Date: Fri, 12 Jul 2019 14:59:53 +0200 [thread overview]
Message-ID: <bf74b176-9321-c175-359d-4c5cf58a72b4@iogearbox.net> (raw)
In-Reply-To: <0143c2e9-ac0d-33de-3019-85016d771c76@fb.com>
On 07/12/2019 08:03 AM, Yonghong Song wrote:
> On 7/10/19 11:53 PM, Andrii Nakryiko wrote:
>> BTF size resolution logic isn't always resolving type size correctly, leading
>> to erroneous map creation failures due to value size mismatch.
>>
>> This patch set:
>> 1. fixes the issue (patch #1);
>> 2. adds tests for trickier cases (patch #2);
>> 3. and converts few test cases utilizing BTF-defined maps, that previously
>> couldn't use typedef'ed arrays due to kernel bug (patch #3).
>>
>> Patch #1 can be applied against bpf tree, but selftest ones (#2 and #3) have
>> to go against bpf-next for now.
>
> Why #2 and #3 have to go to bpf-next? bpf tree also accepts tests,
> AFAIK. Maybe leave for Daniel and Alexei to decide in this particular case.
Yes, corresponding test cases for fixes are also accepted for bpf tree, thanks.
>> Andrii Nakryiko (3):
>> bpf: fix BTF verifier size resolution logic
>> selftests/bpf: add trickier size resolution tests
>> selftests/bpf: use typedef'ed arrays as map values
>
> Looks good to me. Except minor comments in patch 1/3, Ack the series.
> Acked-by: Yonghong Song <yhs@fb.com>
>
>>
>> kernel/bpf/btf.c | 14 ++-
>> .../bpf/progs/test_get_stack_rawtp.c | 3 +-
>> .../bpf/progs/test_stacktrace_build_id.c | 3 +-
>> .../selftests/bpf/progs/test_stacktrace_map.c | 2 +-
>> tools/testing/selftests/bpf/test_btf.c | 88 +++++++++++++++++++
>> 5 files changed, 102 insertions(+), 8 deletions(-)
>>
next prev parent reply other threads:[~2019-07-12 12:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 6:53 [PATCH v2 bpf-next 0/3] fix BTF verification size resolution Andrii Nakryiko
2019-07-11 6:53 ` [PATCH v2 bpf-next 1/3] bpf: fix BTF verifier size resolution logic Andrii Nakryiko
2019-07-12 5:59 ` Yonghong Song
2019-07-12 15:36 ` Andrii Nakryiko
2019-07-12 15:47 ` Yonghong Song
2019-07-12 17:10 ` Andrii Nakryiko
2019-07-11 6:53 ` [PATCH v2 bpf-next 2/3] selftests/bpf: add trickier size resolution tests Andrii Nakryiko
2019-07-11 6:53 ` [PATCH v2 bpf-next 3/3] selftests/bpf: use typedef'ed arrays as map values Andrii Nakryiko
2019-07-12 6:03 ` [PATCH v2 bpf-next 0/3] fix BTF verification size resolution Yonghong Song
2019-07-12 12:59 ` Daniel Borkmann [this message]
2019-07-12 15:42 ` Andrii Nakryiko
2019-07-12 15:51 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf74b176-9321-c175-359d-4c5cf58a72b4@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=Kernel-team@fb.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).