From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A512EC4CEC7 for ; Fri, 13 Sep 2019 02:12:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 884EE2084D for ; Fri, 13 Sep 2019 02:12:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726532AbfIMCM7 (ORCPT ); Thu, 12 Sep 2019 22:12:59 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:25920 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726262AbfIMCM6 (ORCPT ); Thu, 12 Sep 2019 22:12:58 -0400 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x8D2CkAu136516; Thu, 12 Sep 2019 22:12:50 -0400 Received: from ppma01dal.us.ibm.com (83.d6.3fa9.ip4.static.sl-reverse.com [169.63.214.131]) by mx0b-001b2d01.pphosted.com with ESMTP id 2uywkvy5ta-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 12 Sep 2019 22:12:47 -0400 Received: from pps.filterd (ppma01dal.us.ibm.com [127.0.0.1]) by ppma01dal.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id x8D2AB5O017443; Fri, 13 Sep 2019 02:12:11 GMT Received: from b03cxnp07029.gho.boulder.ibm.com (b03cxnp07029.gho.boulder.ibm.com [9.17.130.16]) by ppma01dal.us.ibm.com with ESMTP id 2uyw58jej7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 13 Sep 2019 02:12:11 +0000 Received: from b03ledav005.gho.boulder.ibm.com (b03ledav005.gho.boulder.ibm.com [9.17.130.236]) by b03cxnp07029.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x8D2C97N57737610 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 13 Sep 2019 02:12:09 GMT Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B79B0BE056; Fri, 13 Sep 2019 02:12:09 +0000 (GMT) Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 91C01BE051; Fri, 13 Sep 2019 02:12:07 +0000 (GMT) Received: from [9.199.46.176] (unknown [9.199.46.176]) by b03ledav005.gho.boulder.ibm.com (Postfix) with ESMTP; Fri, 13 Sep 2019 02:12:07 +0000 (GMT) Subject: Re: [Ksummit-discuss] [PATCH v2 3/3] libnvdimm, MAINTAINERS: Maintainer Entry Profile To: Dan Carpenter , Dan Williams Cc: Dave Jiang , linux-nvdimm@lists.01.org, Vishal Verma , linux-kernel@vger.kernel.org, bpf@vger.kernel.org References: <156821692280.2951081.18036584954940423225.stgit@dwillia2-desk3.amr.corp.intel.com> <156821693963.2951081.11214256396118531359.stgit@dwillia2-desk3.amr.corp.intel.com> <20190911184332.GL20699@kadam> From: "Aneesh Kumar K.V" Message-ID: Date: Fri, 13 Sep 2019 07:41:55 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190911184332.GL20699@kadam> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-09-13_01:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1909130022 Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On 9/12/19 12:13 AM, Dan Carpenter wrote: > On Wed, Sep 11, 2019 at 08:48:59AM -0700, Dan Williams wrote: >> +Coding Style Addendum >> +--------------------- >> +libnvdimm expects multi-line statements to be double indented. I.e. >> + >> + if (x... >> + && ...y) { > > That looks horrible and it causes a checkpatch warning. :( Why not > do it the same way that everyone else does it. > > if (blah_blah_x && <-- && has to be on the first line for checkpatch > blah_blah_y) { <-- [tab][space][space][space][space]blah > > Now all the conditions are aligned visually which makes it readable. > They aren't aligned with the indent block so it's easy to tell the > inside from the if condition. I came across this while sending patches to libnvdimm subsystem. W.r.t coding Style can we have consistent styles across the kernel? Otherwise, one would have to change the editor settings as they work across different subsystems in the kernel. In this specific case both clang-format and emacs customization tip in the kernel documentation directory suggest the later style. -aneesh