bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Borkmann <daniel@iogearbox.net>
To: Andrii Nakryiko <andriin@fb.com>,
	bpf@vger.kernel.org, netdev@vger.kernel.org, ast@fb.com
Cc: andrii.nakryiko@gmail.com, kernel-team@fb.com
Subject: Re: [PATCH bpf-next] tools/runqslower: add BPF_F_CURRENT_CPU for running selftest on older kernels
Date: Wed, 11 Mar 2020 15:19:20 +0100	[thread overview]
Message-ID: <c622d372-f4a8-e080-3843-df22f926142f@iogearbox.net> (raw)
In-Reply-To: <20200311043010.530620-1-andriin@fb.com>

On 3/11/20 5:30 AM, Andrii Nakryiko wrote:
> Libbpf compiles and runs subset of selftests on each PR in its Github mirror
> repository. To allow still building up-to-date selftests against outdated
> kernel images, add back BPF_F_CURRENT_CPU definitions back.
> N.B. BCC's runqslower version ([0]) doesn't need BPF_F_CURRENT_CPU due to use of
> locally checked in vmlinux.h, generated against kernel with 1aae4bdd7879 ("bpf:
> Switch BPF UAPI #define constants used from BPF program side to enums")
> applied.
>    [0] https://github.com/iovisor/bcc/pull/2809
> Fixes: 367d82f17eff (" tools/runqslower: Drop copy/pasted BPF_F_CURRENT_CPU definiton")
> Signed-off-by: Andrii Nakryiko <andriin@fb.com>

Too bad, applied, thanks!

      reply	other threads:[~2020-03-11 14:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-11  4:30 [PATCH bpf-next] tools/runqslower: add BPF_F_CURRENT_CPU for running selftest on older kernels Andrii Nakryiko
2020-03-11 14:19 ` Daniel Borkmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c622d372-f4a8-e080-3843-df22f926142f@iogearbox.net \
    --to=daniel@iogearbox.net \
    --cc=andrii.nakryiko@gmail.com \
    --cc=andriin@fb.com \
    --cc=ast@fb.com \
    --cc=bpf@vger.kernel.org \
    --cc=kernel-team@fb.com \
    --cc=netdev@vger.kernel.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).