From: Delyan Kratunov <delyank@fb.com>
To: "daniel@iogearbox.net" <daniel@iogearbox.net>,
"ast@kernel.org" <ast@kernel.org>,
"andrii@kernel.org" <andrii@kernel.org>,
"lkp@intel.com" <lkp@intel.com>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>
Cc: "kbuild-all@lists.01.org" <kbuild-all@lists.01.org>
Subject: Re: [PATCH bpf-next v2 2/5] bpf: implement sleepable uprobes by chaining tasks_trace and normal rcu
Date: Tue, 3 May 2022 17:20:26 +0000 [thread overview]
Message-ID: <c7819d752137cf93be454c117812bb1c2c1866e4.camel@fb.com> (raw)
In-Reply-To: <202205031441.1fhDuUQK-lkp@intel.com>
On Tue, 2022-05-03 at 14:30 +0800, kernel test robot wrote:
> Hi Delyan,
>
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on bpf-next/master]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Delyan-Kratunov/sleepable-uprobe-support/20220503-071247
> base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
> config: i386-defconfig (https://download.01.org/0day-ci/archive/20220503/202205031441.1fhDuUQK-lkp@intel.com/config )
> compiler: gcc-11 (Debian 11.2.0-20) 11.2.0
> reproduce (this is a W=1 build):
> # https://github.com/intel-lab-lkp/linux/commit/cfa0f114829902b579da16d7520a39317905c502
> git remote add linux-review https://github.com/intel-lab-lkp/linux
> git fetch --no-tags linux-review Delyan-Kratunov/sleepable-uprobe-support/20220503-071247
> git checkout cfa0f114829902b579da16d7520a39317905c502
> # save the config file
> mkdir build_dir && cp config build_dir/.config
> make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> kernel/trace/trace_uprobe.c: In function '__uprobe_perf_func':
> > > kernel/trace/trace_uprobe.c:1349:23: error: implicit declaration of function 'uprobe_call_bpf'; did you mean 'trace_call_bpf'? [-Werror=implicit-function-declaration]
> 1349 | ret = uprobe_call_bpf(call, regs);
> | ^~~~~~~~~~~~~~~
> | trace_call_bpf
> cc1: some warnings being treated as errors
Hm, CONFIG_BPF_EVENTS doesn't seem to guard the callsite from trace_uprobe.c, it's
only gated by CONFIG_PERF_EVENTS there. A PERF_EVENTS=y && BPF_EVENTS=n config would
lead to this error.
This is a pre-existing issue and I'll send a separate patch for it.
next prev parent reply other threads:[~2022-05-03 17:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-02 23:09 [PATCH bpf-next v2 0/5] sleepable uprobe support Delyan Kratunov
2022-05-02 23:09 ` [PATCH bpf-next v2 3/5] bpf: allow sleepable uprobe programs to attach Delyan Kratunov
2022-05-09 23:52 ` Andrii Nakryiko
2022-05-02 23:09 ` [PATCH bpf-next v2 5/5] selftests/bpf: add tests for sleepable kprobes and uprobes Delyan Kratunov
2022-05-09 23:57 ` Andrii Nakryiko
2022-05-02 23:09 ` [PATCH bpf-next v2 4/5] libbpf: add support for sleepable kprobe and uprobe programs Delyan Kratunov
2022-05-09 23:53 ` Andrii Nakryiko
2022-05-02 23:09 ` [PATCH bpf-next v2 2/5] bpf: implement sleepable uprobes by chaining tasks_trace and normal rcu Delyan Kratunov
2022-05-03 6:30 ` kernel test robot
2022-05-03 17:20 ` Delyan Kratunov [this message]
2022-05-09 23:58 ` Andrii Nakryiko
2022-05-10 2:54 ` Alexei Starovoitov
2022-05-03 8:48 ` kernel test robot
2022-05-10 3:02 ` Alexei Starovoitov
2022-05-02 23:09 ` [PATCH bpf-next v2 1/5] bpf: move bpf_prog to bpf.h Delyan Kratunov
2022-05-10 3:04 ` Alexei Starovoitov
2022-05-13 1:22 ` Delyan Kratunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7819d752137cf93be454c117812bb1c2c1866e4.camel@fb.com \
--to=delyank@fb.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kbuild-all@lists.01.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).