From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC5D5C43461 for ; Wed, 21 Apr 2021 15:27:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 91F5561449 for ; Wed, 21 Apr 2021 15:27:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237667AbhDUP1o (ORCPT ); Wed, 21 Apr 2021 11:27:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243436AbhDUP1o (ORCPT ); Wed, 21 Apr 2021 11:27:44 -0400 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A679C06138A for ; Wed, 21 Apr 2021 08:27:09 -0700 (PDT) Received: by mail-wm1-x32e.google.com with SMTP id w7-20020a1cdf070000b0290125f388fb34so1547753wmg.0 for ; Wed, 21 Apr 2021 08:27:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=isovalent-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=gKdt8Wk+0o9N/o4Eeh7jFivsYAp+6odRUk2hDoOYTNE=; b=Ld1STCnsE1eouA8OovEt+JR3kvLhy+38SIeXNlwIkDlOiLq05bK7Xtf0K9jrzy0JBg l7Vv9cqjwitQLtZanAgbC4FHzf0jZYrRiLFa1aiMF+HviBubCWXTbitrlhIeZgclqfrr rNSiHWguSr/4GVnfTLurIDqrGY85zcHBi1fjyNVIwnwt04M07BxCWghuUhWyyCRBw0PQ kODch46wzB/NfbSZH3OkAXLF7Scy075Euz1AgKCdsC/jqLZFujuUsUSTB9qK2x31ltBH td1grGFzAsMrRdOHHH0QYY+3dvXwt//4U27ImWFpSaFnt7wVbc0SpT/Y+WZBQRPuwY4A rcLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=gKdt8Wk+0o9N/o4Eeh7jFivsYAp+6odRUk2hDoOYTNE=; b=uEHNqQ2TlR6jga8YmDYPNKLEwf8vYcCr23f6+dXZyhbjwWcSGZGEA4gz2suUY9bkHo 11Sn2Jj0zd9c/EWNmPIazhq96JsfVewuk6z0HQiUWDUyI4e4Q9tRpGtDCSa9AyACDQpp m/RshdndKhuaEQgylD+8boZuK7bW1mCQK/gC4u9e2h/GwDMOoGN4XS16dJEnpTedUOFQ DuQYE2GQxz60IWERyepALcYGLDy+jgdWGX8KczkP8aVbVIKXnHMZ8rJebztpxAZcJ3kb k056bJev59em7s+SLkvW9hE/e+AY9noson2NFyO8/WvKdYcX92xsdHhI4Li9EEQTeE9j UQZQ== X-Gm-Message-State: AOAM531xdCn9XTuKlK84zGFHmjKZOF6cNT28xkHg2h5yIQcoEfcO1ZqS 4xSgLZZOXFdZlzxNn/byDrkY5g== X-Google-Smtp-Source: ABdhPJx/Z4/wH0IczXzrpu1/+CHFDyPCB4UahTsagrUa+vs9LV/LiT8hoPliplY5euRpNBomq4NZqQ== X-Received: by 2002:a1c:1f8e:: with SMTP id f136mr10451672wmf.17.1619018828018; Wed, 21 Apr 2021 08:27:08 -0700 (PDT) Received: from [192.168.1.8] ([149.86.81.177]) by smtp.gmail.com with ESMTPSA id n2sm3159970wmb.32.2021.04.21.08.27.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Apr 2021 08:27:07 -0700 (PDT) Subject: Re: [PATCH bpf-next 1/2] bpf: Remove bpf_jit_enable=2 debugging mode To: Christophe Leroy , Alexei Starovoitov Cc: Ian Rogers , Song Liu , "open list:DOCUMENTATION" , Zi Shen Lim , Paul Walmsley , Alexei Starovoitov , Andrii Nakryiko , Paul Mackerras , Sandipan Das , "H. Peter Anvin" , sparclinux@vger.kernel.org, Shubham Bansal , Mahesh Bandewar , Will Deacon , Nicolas Dichtel , linux-s390 , Ilya Leoshkevich , paulburton@kernel.org, Jonathan Corbet , Mauro Carvalho Chehab , Masahiro Yamada , X86 ML , John Fastabend , Russell King , linux-riscv , Christian Borntraeger , Ingo Molnar , linux-arm-kernel , Catalin Marinas , "Naveen N . Rao" , Jakub Kicinski , Tobias Klauser , linux-mips@vger.kernel.org, grantseltzer@gmail.com, Xi Wang , Albert Ou , Kees Cook , Vasily Gorbik , Luke Nelson , LKML , Heiko Carstens , ppc-dev , KP Singh , iecedge@gmail.com, Simon Horman , Borislav Petkov , Alexander Viro , Yonghong Song , Thomas Gleixner , Dmitry Vyukov , tsbogend@alpha.franken.de, Daniel Borkmann , Hideaki YOSHIFUJI , Network Development , David Ahern , Wang YanQing , Martin KaFai Lau , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Palmer Dabbelt , bpf , Jianlin Lv , "David S. Miller" References: <20210415093250.3391257-1-Jianlin.Lv@arm.com> <9c4a78d2-f73c-832a-e6e2-4b4daa729e07@iogearbox.net> <0dea05ba-9467-0d84-4515-b8766f60318e@csgroup.eu> <7dc31256-eb1d-dc93-5e55-2de27475e0c6@csgroup.eu> From: Quentin Monnet Message-ID: Date: Wed, 21 Apr 2021 16:27:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <7dc31256-eb1d-dc93-5e55-2de27475e0c6@csgroup.eu> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org 2021-04-21 15:10 UTC+0200 ~ Christophe Leroy > > > Le 20/04/2021 à 05:28, Alexei Starovoitov a écrit : >> On Sat, Apr 17, 2021 at 1:16 AM Christophe Leroy >> wrote: >>> >>> >>> >>> Le 16/04/2021 à 01:49, Alexei Starovoitov a écrit : >>>> On Thu, Apr 15, 2021 at 8:41 AM Quentin Monnet >>>> wrote: >>>>> >>>>> 2021-04-15 16:37 UTC+0200 ~ Daniel Borkmann >>>>>> On 4/15/21 11:32 AM, Jianlin Lv wrote: >>>>>>> For debugging JITs, dumping the JITed image to kernel log is >>>>>>> discouraged, >>>>>>> "bpftool prog dump jited" is much better way to examine JITed dumps. >>>>>>> This patch get rid of the code related to bpf_jit_enable=2 mode and >>>>>>> update the proc handler of bpf_jit_enable, also added auxiliary >>>>>>> information to explain how to use bpf_jit_disasm tool after this >>>>>>> change. >>>>>>> >>>>>>> Signed-off-by: Jianlin Lv >>>>> >>>>> Hello, >>>>> >>>>> For what it's worth, I have already seen people dump the JIT image in >>>>> kernel logs in Qemu VMs running with just a busybox, not for kernel >>>>> development, but in a context where buiding/using bpftool was not >>>>> possible. >>>> >>>> If building/using bpftool is not possible then majority of selftests >>>> won't >>>> be exercised. I don't think such environment is suitable for any kind >>>> of bpf development. Much so for JIT debugging. >>>> While bpf_jit_enable=2 is nothing but the debugging tool for JIT >>>> developers. >>>> I'd rather nuke that code instead of carrying it from kernel to kernel. >>>> >>> >>> When I implemented JIT for PPC32, it was extremely helpfull. >>> >>> As far as I understand, for the time being bpftool is not usable in >>> my environment because it >>> doesn't support cross compilation when the target's endianess differs >>> from the building host >>> endianess, see discussion at >>> https://lore.kernel.org/bpf/21e66a09-514f-f426-b9e2-13baab0b938b@csgroup.eu/ >>> >>> >>> That's right that selftests can't be exercised because they don't build. >>> >>> The question might be candid as I didn't investigate much about the >>> replacement of "bpf_jit_enable=2 >>> debugging mode" by bpftool, how do we use bpftool exactly for that ? >>> Especially when using the BPF >>> test module ? >> >> the kernel developers can add any amount of printk and dumps to debug >> their code, >> but such debugging aid should not be part of the production kernel. >> That sysctl was two things at once: debugging tool for kernel devs and >> introspection for users. >> bpftool jit dump solves the 2nd part. It provides JIT introspection to >> users. >> Debugging of the kernel can be done with any amount of auxiliary code >> including calling print_hex_dump() during jiting. >> > > I get the following message when trying the command suggested in the > patch message: > > root@vgoip:~# ./bpftool prog dump jited > Error: No libbfd support > > Christophe Hi Christophe, Bpftool relies on libbfd to disassemble the JIT-ed instructions, but this is an optional dependency and your version of bpftool has been compiled without it. You could try to install it on your system (it is usually shipped with binutils, package "binutils-dev" on Ubuntu for example). If you want to cross-compile bpftool, the libbfd version provided by your distribution may not include support for the target architecture. In that case you would have to build libbfd yourself to make sure it supports it. Then you can clean up the results from the libbfd probing: $ make -C tools/build/feature/ clean and recompile bpftool. I hope this helps, Quentin