From: Ilya Leoshkevich <iii@linux.ibm.com>
To: Ian Denhardt <ian@zenhack.net>,
ast@kernel.org, daniel@iogearbox.net, bpf@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: More strict error checking in bpf_asm?
Date: Tue, 23 Feb 2021 21:47:32 +0100 [thread overview]
Message-ID: <c964892195a6b91d20a67691448567ef528ffa6d.camel@linux.ibm.com> (raw)
In-Reply-To: <161411199784.11959.16534412799839825563@localhost.localdomain>
On Tue, 2021-02-23 at 15:26 -0500, Ian Denhardt wrote:
> Hi,
>
> I'm using the `bpf_asm` tool to do some syscall filtering, and found
> out
> the hard way that its error checking isn't very strict. In particular,
> it issues a warning (not an error) when a jump offset overflows the
> instruction's field. It really seems like this *ought* to be a hard
> error, but I see from the commit message in
> 7e22077d0c73a68ff3fd8b3d2f6564fcbcf8cb23 that this was left as a
> warning
> due to backwards compatibility concerns.
My 2c: when I was writing that commit, I did not have any specific
examples of code that would break in mind - that was pure
speculation/paranoia. So it's OK from my perspective to convert this
fprintf to a hard error.
[...]
prev parent reply other threads:[~2021-02-23 20:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 20:26 More strict error checking in bpf_asm? Ian Denhardt
2021-02-23 20:47 ` Ilya Leoshkevich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c964892195a6b91d20a67691448567ef528ffa6d.camel@linux.ibm.com \
--to=iii@linux.ibm.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=ian@zenhack.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).