From: Jesper Dangaard Brouer <jbrouer@redhat.com>
To: bpf@vger.kernel.org, "Stanislav Fomichev" <sdf@google.com>,
"Toke Høiland-Jørgensen" <toke@redhat.com>
Cc: brouer@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, martin.lau@kernel.org,
ast@kernel.org, daniel@iogearbox.net, alexandr.lobakin@intel.com,
larysa.zaremba@intel.com, xdp-hints@xdp-project.net,
anthony.l.nguyen@intel.com, yoong.siang.song@intel.com,
boon.leong.ong@intel.com, intel-wired-lan@lists.osuosl.org,
pabeni@redhat.com, jesse.brandeburg@intel.com, kuba@kernel.org,
edumazet@google.com, john.fastabend@gmail.com, hawk@kernel.org,
davem@davemloft.net, tariqt@nvidia.com
Subject: Re: [PATCH bpf V5 0/5] XDP-hints: API change for RX-hash kfunc bpf_xdp_metadata_rx_hash
Date: Sat, 1 Apr 2023 18:47:06 +0200 [thread overview]
Message-ID: <d4b3a22a-c815-a337-29b1-737efd9a7494@redhat.com> (raw)
In-Reply-To: <168028882260.4030852.1100965689789226162.stgit@firesoul>
Why have this patchset[1] been marked "Changes Requested" ?
Notice: The BPF test_progs are failing on "xdp_do_redirect", but that is
not related to this patchset as it already happens on a clean bpf-tree.
[1]
https://patchwork.kernel.org/project/netdevbpf/list/?series=735957&state=%2A
On 31/03/2023 20.54, Jesper Dangaard Brouer wrote:
> Current API for bpf_xdp_metadata_rx_hash() returns the raw RSS hash value,
> but doesn't provide information on the RSS hash type (part of 6.3-rc).
>
> This patchset proposal is to change the function call signature via adding
> a pointer value argument for providing the RSS hash type.
>
> ---
> V5:
> - Fixes for checkpatch.pl
> - Change function signature for all xmo_rx_hash calls in patch1
>
> Jesper Dangaard Brouer (5):
> xdp: rss hash types representation
> mlx5: bpf_xdp_metadata_rx_hash add xdp rss hash type
> veth: bpf_xdp_metadata_rx_hash add xdp rss hash type
> mlx4: bpf_xdp_metadata_rx_hash add xdp rss hash type
> selftests/bpf: Adjust bpf_xdp_metadata_rx_hash for new arg
>
>
> drivers/net/ethernet/mellanox/mlx4/en_rx.c | 22 ++++++-
> drivers/net/ethernet/mellanox/mlx4/mlx4_en.h | 3 +-
> .../net/ethernet/mellanox/mlx5/core/en/xdp.c | 63 ++++++++++++++++++-
> drivers/net/veth.c | 10 ++-
> include/linux/mlx5/device.h | 14 ++++-
> include/linux/netdevice.h | 3 +-
> include/net/xdp.h | 47 ++++++++++++++
> net/core/xdp.c | 10 ++-
> .../selftests/bpf/prog_tests/xdp_metadata.c | 2 +
> .../selftests/bpf/progs/xdp_hw_metadata.c | 14 +++--
> .../selftests/bpf/progs/xdp_metadata.c | 6 +-
> .../selftests/bpf/progs/xdp_metadata2.c | 7 ++-
> tools/testing/selftests/bpf/xdp_hw_metadata.c | 2 +-
> tools/testing/selftests/bpf/xdp_metadata.h | 1 +
> 14 files changed, 180 insertions(+), 24 deletions(-)
>
> --
>
next prev parent reply other threads:[~2023-04-01 16:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-31 18:54 [PATCH bpf V5 0/5] XDP-hints: API change for RX-hash kfunc bpf_xdp_metadata_rx_hash Jesper Dangaard Brouer
2023-03-31 18:55 ` [PATCH bpf V5 1/5] xdp: rss hash types representation Jesper Dangaard Brouer
2023-03-31 18:55 ` [PATCH bpf V5 2/5] mlx5: bpf_xdp_metadata_rx_hash add xdp rss hash type Jesper Dangaard Brouer
2023-03-31 18:55 ` [PATCH bpf V5 3/5] veth: " Jesper Dangaard Brouer
2023-03-31 18:55 ` [PATCH bpf V5 4/5] mlx4: " Jesper Dangaard Brouer
2023-03-31 18:55 ` [PATCH bpf V5 5/5] selftests/bpf: Adjust bpf_xdp_metadata_rx_hash for new arg Jesper Dangaard Brouer
2023-04-01 16:47 ` Jesper Dangaard Brouer [this message]
2023-04-02 8:37 ` [PATCH bpf V5 0/5] XDP-hints: API change for RX-hash kfunc bpf_xdp_metadata_rx_hash Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4b3a22a-c815-a337-29b1-737efd9a7494@redhat.com \
--to=jbrouer@redhat.com \
--cc=alexandr.lobakin@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=ast@kernel.org \
--cc=boon.leong.ong@intel.com \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=larysa.zaremba@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@google.com \
--cc=tariqt@nvidia.com \
--cc=toke@redhat.com \
--cc=xdp-hints@xdp-project.net \
--cc=yoong.siang.song@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).