From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0363C4320D for ; Tue, 24 Sep 2019 18:23:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9F6EA20872 for ; Tue, 24 Sep 2019 18:23:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569349396; bh=iCNiR4tBtXuRZYAUy/xyFEkWzCo50BqAObX9LieHpg0=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=BOiCuL2agGty/1fuQU45g9Xj9ma+Mmuuok28zzSy48G3SefS9I/W9ccJH34L+/cyz PMwmpw18b0OsNCxGENaWOJn1stDQ9HBKhwYG1bKMTkPgnrxd43bESoEbkjEM/K+6ig OYweqSBm1ZZ9wEfeiQWoRph0nL4CbNxw6l8cMPGk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2395470AbfIXSXQ (ORCPT ); Tue, 24 Sep 2019 14:23:16 -0400 Received: from mail-io1-f44.google.com ([209.85.166.44]:45732 "EHLO mail-io1-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726339AbfIXSXO (ORCPT ); Tue, 24 Sep 2019 14:23:14 -0400 Received: by mail-io1-f44.google.com with SMTP id c25so6788226iot.12 for ; Tue, 24 Sep 2019 11:23:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=JCRwRvIn5WnSIjJ8UCyA8yQaqy8F1gjAcRkVOQB7q9I=; b=Ep9nbVOXt43g2GclKMujhZBtqpVD24/fugjF20R07gEhpQOmpgtpTnMiipYTlVRUsh x0q1dnIC70qIcrWtw7LA9CSHAIi0jLFwtDGGedygehl5k1u3uvQec64chGwkXexJ7E70 aHb8Qxu2dI/iGt/P03nuAL0MHi1aovz5lzpuU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JCRwRvIn5WnSIjJ8UCyA8yQaqy8F1gjAcRkVOQB7q9I=; b=EKdx2fgJUVPJBmIoxJZ5ga/vh4hFxlfm40rHOQdJDuzERgkcfAFQYfqLW2bHqYo8eX xERm7LfHw1Sg4nsfnVM+yOqn6Y16mxPB6hPz38iY/Z+efGw6Tevku2ev1/Ap+UNDYvrE Y/BwDav7zMi9FITSglrgsGNTHx27sJfmLp/1dfHIseHyiycChlZiWCq70nETNz8gWpkG kncxSLegSfcT9it3J/C9VttsTU/pbAdm3f1oxSYTAN3jswhSOdX4ex6kz6SE+BGB8OOl vZows619V6coW7+xu/44LJ8h3bBbWSk9+BFh9QjNOiEchKwmf7RtyEze2QzebGgP5LOS VTtw== X-Gm-Message-State: APjAAAXa0DASGziiNa1BJTje4zIBl+a9DBTzAZqtWjOW5RnFVmHKHZfY X4TD0ZpvSmRvg8vDWvUle7PM1Q== X-Google-Smtp-Source: APXvYqxK0F4oMWpvW+erHciK5obgRJA5cW6Px156FnlU93cw6O2tYswirK5NqitWoQDlIgoeKiloJw== X-Received: by 2002:a02:246:: with SMTP id 67mr106308jau.121.1569349393695; Tue, 24 Sep 2019 11:23:13 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id f26sm1242052ion.4.2019.09.24.11.23.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Sep 2019 11:23:13 -0700 (PDT) Subject: Re: Linux 5.4 - bpf test build fails To: Tim.Bird@sony.com, cristian.marussi@arm.com, alexei.starovoitov@gmail.com, daniel@iogearbox.net Cc: linux-kselftest@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, davem@davemloft.net, "skh >> Shuah Khan" References: <742ecabe-45ce-cf6e-2540-25d6dc23c45f@linuxfoundation.org> <1d1bbc01-5cf4-72e6-76b3-754d23366c8f@arm.com> <34a9bd63-a251-0b4f-73b6-06b9bbf9d3fa@linuxfoundation.org> From: Shuah Khan Message-ID: Date: Tue, 24 Sep 2019 12:23:12 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On 9/24/19 12:07 PM, Tim.Bird@sony.com wrote: > > >> -----Original Message----- >> From: Cristian Marussi on Tuesday, September 24, 2019 7:30 AM >> >> Hi Shuah >> >> On 24/09/2019 17:39, Shuah Khan wrote: >>> On 9/24/19 10:03 AM, Shuah Khan wrote: >>>> On 9/24/19 9:52 AM, Cristian Marussi wrote: >>>>> Hi Shuah >>>>> >>>>> On 24/09/2019 16:26, Shuah Khan wrote: >>>>>> Hi Alexei and Daniel, >>>>>> >>>>>> bpf test doesn't build on Linux 5.4 mainline. Do you know what's >>>>>> happening here. >>>>>> >>>>>> >>>>>> make -C tools/testing/selftests/bpf/ >>>>> >>>>> side question, since I'm writing arm64/ tests. >>>>> >>>>> my "build-testcases" following the KSFT docs are: >>>>> >>>>> make kselftest >>>>> make TARGETS=arm64 kselftest >>>>> make -C tools/testing/selftests/ >>>>> make -C tools/testing/selftests/ INSTALL_PATH= install >>>>> make TARGETS=arm64 -C tools/testing/selftests/ >>>>> make TARGETS=arm64 -C tools/testing/selftests/ >>>>> INSTALL_PATH= install >>>>> ./kselftest_install.sh >>> >>> Cristian, >>> >>> That being said, I definitely want to see this list limited to >>> a few options. >>> >>> One problem is that if somebody wants to do just a build, there >>> is no option from the main makefile. I have sent support for that >>> a few months ago and the patch didn't got lost it appears. I am >>> working on resending those patches. The same is true for install. >>> I sent in a patch for that a while back and I am going to resend. >>> These will make it easier for users. >>> >>> I would really want to get to supporting only these options: >>> >>> These are supported now: >>> >>> make kselftest >>> make TARGETS=arm64 kselftest (one or more targets) >>> >>> Replace the following: >>> >>> make -C tools/testing/selftests/ with >>> >>> make kselftes_build option from main makefile >>> >>> Replace this: >>> make -C tools/testing/selftests/ INSTALL_PATH= install >>> >>> with >>> make kselftest_install >> >> Yes these top level options would be absolutely useful to avoid multiplication >> of build targets to support and test. >> >> Moreover, currently, since there was a lot of test growing into arm64/ >> inside subdirs like arm64/signal, I support (still under review in fact) in the >> arm64/ >> toplevel makefile the possibility of building/installing by subdirs only, in order >> to be able to limit what you want to build/install of a TARGET (resulting in >> quicker devel), >> issuing something like: >> >> make TARGETS=arm64 SUBTARGETS=signal -C tools/testing/selftests/ >> >> if possible, that would be useful if kept functional even in the >> new schema. I mean being able to still issue: >> >> make TARGETS=arm64 SUBTARGETS=signal kselftes_build > > From a user perspective, instead of adding a new SUBTARGETS variable, > I would prefer something like the following: > > make TARGET=arm64/signal kselftest_build > > If you just add a single flat subsidiary namespace, then it doesn't support further > increasing the directory depth in the future. > TARGETS is make variable. Adding sub-targets might not be easy without cluttering the selftests main Makefile. I will have to look into it. thanks, -- Shuah