From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C336CC54EB4 for ; Sun, 22 Jan 2023 11:45:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229866AbjAVLo6 (ORCPT ); Sun, 22 Jan 2023 06:44:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229841AbjAVLo5 (ORCPT ); Sun, 22 Jan 2023 06:44:57 -0500 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 913EE1F5C4 for ; Sun, 22 Jan 2023 03:44:54 -0800 (PST) Received: by mail-wr1-x432.google.com with SMTP id q5so3801434wrv.0 for ; Sun, 22 Jan 2023 03:44:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9d3PHM1i18b1wVBT1Cbc8b3/F4tYcjxcOJc7IXM78Rc=; b=K0ogjQy2dBIWpRyp2G9Qo7zgLe2LmkcCsc+/SJfNrUrZoMYVAXj6EBfqqAOZO90TQV 8dFrqB0UpP/FL5YLyW8DaYdSIo3BYZ6jWVhbXvikqhFRDlopOedRj2dISYn4JPdf7JlA KzsoTNkcC/dbTzg7fLyddp/61eGwSN2pamhISQfxDpHBGfDt3yL8nejAvTR/KmsWSzBc ZctPEB9rXXjRaaTZa8ZJCKpvyefetvL+86WKhHd1yI+EgTIvtBe9bo4ok2He/FWqHs64 qAR5wQT5taDHiDtKTbA0eAIGDoMBI78QD27Fart3ivhlaqTZYemt5SCMPsmsKsWIv5F1 gxSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9d3PHM1i18b1wVBT1Cbc8b3/F4tYcjxcOJc7IXM78Rc=; b=H2F8r+9Rd0BxQ4nqftewSYL2X1tXOepzxmAzbmTJY70bRYFkWdkopY7nxch05wlStj DxExafhPZ3mwO0BobgG2UB5kQ/MbvnCsLEQGa3Dxa1JyQHgq3NZ7RzqLdZ+ckQI7QNLE NYKK3jK7GlxaeffrmVsdLPHzYnC3j34Y4hqMAgT+45rmHPogimAbDhseKF56tv1saimv gfmjFu8ZGO0bhMBRyk883VNMrt+SS+KlppY388Y0tUvQD5K0VMvdiCtCR1kt02vqDHgl 5Vv87V3NRkC+Bpo49BHVOosUFLCc+H2/KE8WxlAzc+W1KsfA9yKl0GrbT0JSQsBaR56L wVvw== X-Gm-Message-State: AFqh2kopUfggdrYSeV6Qbjj4zEWeRzvGEdLk5o3+LqKtD2ofRoTcs40i PP5U4upnnADQMqXsvp1ihaS3ow== X-Google-Smtp-Source: AMrXdXu83lehx7RbHAkRbhG1oMGJmZelEHb0lgNU+pigubgLCdZ9/atDxUOwXiCGtf72XF5Pmi0c8Q== X-Received: by 2002:a05:6000:1f14:b0:2bb:5adc:9f92 with SMTP id bv20-20020a0560001f1400b002bb5adc9f92mr18054855wrb.50.1674387892997; Sun, 22 Jan 2023 03:44:52 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id r8-20020a056000014800b0027323b19ecesm2830431wrx.16.2023.01.22.03.44.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 Jan 2023 03:44:52 -0800 (PST) Message-ID: Date: Sun, 22 Jan 2023 12:44:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [RFC PATCH v2 02/31] Documentation: Add binding for kalray,kv3-1-core-intc Content-Language: en-US To: Yann Sionneau , Arnd Bergmann , Jonathan Corbet , Thomas Gleixner , Marc Zyngier , Rob Herring , Krzysztof Kozlowski , Will Deacon , Peter Zijlstra , Boqun Feng , Mark Rutland , Eric Biederman , Kees Cook , Oleg Nesterov , Ingo Molnar , Waiman Long , "Aneesh Kumar K.V" , Andrew Morton , Nick Piggin , Paul Moore , Eric Paris , Christian Brauner , Paul Walmsley , Palmer Dabbelt , Albert Ou , Jules Maselbas , Guillaume Thouvenin , Clement Leger , Vincent Chardon , =?UTF-8?Q?Marc_Poulhi=c3=a8s?= , Julian Vetter , Samuel Jones , Ashley Lesdalons , Thomas Costis , Marius Gligor , Jonathan Borne , Julien Villette , Luc Michel , Louis Morhet , Julien Hascoet , Jean-Christophe Pince , Guillaume Missonnier , Alex Michon , Huacai Chen , WANG Xuerui , Shaokun Zhang , John Garry , Guangbin Huang , Bharat Bhushan , Bibo Mao , Atish Patra , "Jason A. Donenfeld" , Qi Liu , Jiaxun Yang , Catalin Marinas , Mark Brown , Janosch Frank , Alexey Dobriyan Cc: Benjamin Mugnier , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-audit@redhat.com, linux-riscv@lists.infradead.org, bpf@vger.kernel.org References: <20230120141002.2442-1-ysionneau@kalray.eu> <20230120141002.2442-3-ysionneau@kalray.eu> From: Krzysztof Kozlowski In-Reply-To: <20230120141002.2442-3-ysionneau@kalray.eu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On 20/01/2023 15:09, Yann Sionneau wrote: > From: Jules Maselbas Use subject prefixes matching the subsystem (which you can get for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching). > > Add documentation for `kalray,kv3-1-core-intc` binding. > > Co-developed-by: Jules Maselbas > Signed-off-by: Jules Maselbas > Signed-off-by: Yann Sionneau > --- > > Notes: > V1 -> V2: new patch > > .../kalray,kv3-1-core-intc.yaml | 46 +++++++++++++++++++ > 1 file changed, 46 insertions(+) > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/kalray,kv3-1-core-intc.yaml > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/kalray,kv3-1-core-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/kalray,kv3-1-core-intc.yaml > new file mode 100644 > index 000000000000..1e3d0593173a > --- /dev/null > +++ b/Documentation/devicetree/bindings/interrupt-controller/kalray,kv3-1-core-intc.yaml > @@ -0,0 +1,46 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/interrupt-controller/kalray,kv3-1-core-intc# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Kalray kv3-1 Core Interrupt Controller > + > +description: | > + The Kalray Core Interrupt Controller is tightly integrated in each kv3 core > + present in the Coolidge SoC. > + > + It provides the following features: > + - 32 independent interrupt sources > + - 2-bit configurable priority level > + - 2-bit configurable ownership level > + > +allOf: > + - $ref: /schemas/interrupt-controller.yaml# > + > +properties: > + compatible: > + const: kalray,kv3-1-core-intc Blank line between each of these, > + "#interrupt-cells": > + const: 1 > + description: > + The IRQ number. > + reg: > + maxItems: 0 ??? No way... What's this? > + "kalray,intc-nr-irqs": Drop quotes. > + description: Number of irqs handled by the controller. Why this is variable per board? Why do you need it ? > + > +required: > + - compatible > + - "#interrupt-cells" > + - interrupt-controller missing additionalProperties: false This binding looks poor, like you started from something odd. Please don't. Take the newest reviewed binding or better example-schema and use it to build yours. This would solve several trivial mistakes and style issues. > + > +examples: > + - | > + intc: interrupt-controller { What's the IO address space? Best regards, Krzysztof