From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0033C4727C for ; Tue, 29 Sep 2020 14:41:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9FD5B20756 for ; Tue, 29 Sep 2020 14:41:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731733AbgI2Ol5 (ORCPT ); Tue, 29 Sep 2020 10:41:57 -0400 Received: from www62.your-server.de ([213.133.104.62]:48698 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728844AbgI2Ol4 (ORCPT ); Tue, 29 Sep 2020 10:41:56 -0400 Received: from sslproxy01.your-server.de ([78.46.139.224]) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1kNGpB-0001qy-WE; Tue, 29 Sep 2020 16:41:50 +0200 Received: from [178.196.57.75] (helo=pc-9.home) by sslproxy01.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNGpB-000Res-QS; Tue, 29 Sep 2020 16:41:49 +0200 Subject: Re: [PATCH] powerpc: net: bpf_jit_comp: Fix misuse of fallthrough To: zhe.he@windriver.com, gustavo@embeddedor.com, netdev@vger.kernel.org, bpf@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <20200928090023.38117-1-zhe.he@windriver.com> From: Daniel Borkmann Message-ID: Date: Tue, 29 Sep 2020 16:41:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20200928090023.38117-1-zhe.he@windriver.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.102.4/25942/Tue Sep 29 15:56:33 2020) Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On 9/28/20 11:00 AM, zhe.he@windriver.com wrote: > From: He Zhe > > The user defined label following "fallthrough" is not considered by GCC > and causes build failure. > > kernel-source/include/linux/compiler_attributes.h:208:41: error: attribute > 'fallthrough' not preceding a case label or default label [-Werror] > 208 define fallthrough _attribute((fallthrough_)) > ^~~~~~~~~~~~~ > > Signed-off-by: He Zhe Applied, thanks! I've also added Fixes tag with df561f6688fe ("treewide: Use fallthrough pseudo-keyword") which added the bug.