From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A6ACC433DF for ; Fri, 31 Jul 2020 00:05:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F28492082E for ; Fri, 31 Jul 2020 00:05:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730797AbgGaAFk (ORCPT ); Thu, 30 Jul 2020 20:05:40 -0400 Received: from www62.your-server.de ([213.133.104.62]:45734 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728086AbgGaAFk (ORCPT ); Thu, 30 Jul 2020 20:05:40 -0400 Received: from sslproxy06.your-server.de ([78.46.172.3]) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1k1IYM-00072b-EH; Fri, 31 Jul 2020 02:05:38 +0200 Received: from [178.196.57.75] (helo=pc-9.home) by sslproxy06.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k1IYM-0001nW-8a; Fri, 31 Jul 2020 02:05:38 +0200 Subject: Re: [PATCH bpf-next] libbpf: make destructors more robust by handling ERR_PTR(err) cases To: Andrii Nakryiko , bpf@vger.kernel.org, netdev@vger.kernel.org, ast@fb.com Cc: andrii.nakryiko@gmail.com, kernel-team@fb.com, Song Liu References: <20200729232148.896125-1-andriin@fb.com> From: Daniel Borkmann Message-ID: Date: Fri, 31 Jul 2020 02:05:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20200729232148.896125-1-andriin@fb.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.102.3/25889/Thu Jul 30 17:03:53 2020) Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On 7/30/20 1:21 AM, Andrii Nakryiko wrote: > Most of libbpf "constructors" on failure return ERR_PTR(err) result encoded as > a pointer. It's a common mistake to eventually pass such malformed pointers > into xxx__destroy()/xxx__free() "destructors". So instead of fixing up > clean up code in selftests and user programs, handle such error pointers in > destructors themselves. This works beautifully for NULL pointers passed to > destructors, so might as well just work for error pointers. > > Suggested-by: Song Liu > Signed-off-by: Andrii Nakryiko Applied, thanks!