bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Borkmann <daniel@iogearbox.net>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Alexei Starovoitov <alexei.starovoitov@gmail.com>,
	Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Ian Rogers <irogers@google.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Pekka Enberg <penberg@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
	Irina Tirdea <irina.tirdea@intel.com>, bpf <bpf@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] libbpf: Define __WORDSIZE if not available
Date: Tue, 9 Jun 2020 22:37:48 +0200	[thread overview]
Message-ID: <d8baea0a-7358-a15b-38e5-850e84eae702@iogearbox.net> (raw)
In-Reply-To: <20200609153445.GF24868@kernel.org>

Hey Arnaldo,

On 6/9/20 5:34 PM, Arnaldo Carvalho de Melo wrote:
> Some systems, such as Android, don't have a define for __WORDSIZE, do it
> in terms of __SIZEOF_LONG__, as done in perf since 2012:
> 
>    http://git.kernel.org/torvalds/c/3f34f6c0233ae055b5
> 
> For reference: https://gcc.gnu.org/onlinedocs/cpp/Common-Predefined-Macros.html
> 
> I build tested it here and Andrii did some Travis CI build tests too.
> 
> Acked-by: Andrii Nakryiko <andriin@fb.com>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

Diff missing?

Thanks,
Daniel

  reply	other threads:[~2020-06-09 20:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-08 16:11 libbpf's hashmap use of __WORDSIZE Arnaldo Carvalho de Melo
2020-06-08 17:32 ` Andrii Nakryiko
2020-06-08 18:12   ` Arnaldo Carvalho de Melo
2020-06-09 15:34   ` [PATCH] libbpf: Define __WORDSIZE if not available Arnaldo Carvalho de Melo
2020-06-09 20:37     ` Daniel Borkmann [this message]
2020-06-09 21:16       ` Arnaldo Carvalho de Melo
2020-06-09 23:21         ` Daniel Borkmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d8baea0a-7358-a15b-38e5-850e84eae702@iogearbox.net \
    --to=daniel@iogearbox.net \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@kernel.org \
    --cc=alexei.starovoitov@gmail.com \
    --cc=andrii.nakryiko@gmail.com \
    --cc=arnaldo.melo@gmail.com \
    --cc=bpf@vger.kernel.org \
    --cc=irina.tirdea@intel.com \
    --cc=irogers@google.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namhyung@kernel.org \
    --cc=penberg@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).