bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Björn Töpel" <bjorn.topel@intel.com>
To: Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
	daniel@iogearbox.net, ast@kernel.org, bpf@vger.kernel.org
Cc: magnus.karlsson@intel.com, john.fastabend@gmail.com
Subject: Re: [PATCH bpf 1/3] xsk: remove dangling function declaration from header file
Date: Wed, 3 Mar 2021 17:33:39 +0100	[thread overview]
Message-ID: <dc996d90-ca03-f469-9056-c09ef16dae60@intel.com> (raw)
In-Reply-To: <20210303155158.15953-2-maciej.fijalkowski@intel.com>

On 2021-03-03 16:51, Maciej Fijalkowski wrote:
> xdp_umem_query() is dead for a long time, drop the declaration from
> include/linux/netdevice.h
> 
> Fixes: c9b47cc1fabc ("xsk: fix bug when trying to use both copy and zero-copy on one queue id")
> Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>

Acked-by: Björn Töpel <bjorn.topel@intel.com>

> ---
>   include/linux/netdevice.h | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index 6cef47b76cc6..226303976310 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -3932,8 +3932,6 @@ int dev_change_xdp_fd(struct net_device *dev, struct netlink_ext_ack *extack,
>   int bpf_xdp_link_attach(const union bpf_attr *attr, struct bpf_prog *prog);
>   u32 dev_xdp_prog_id(struct net_device *dev, enum bpf_xdp_mode mode);
>   
> -int xdp_umem_query(struct net_device *dev, u16 queue_id);
> -
>   int __dev_forward_skb(struct net_device *dev, struct sk_buff *skb);
>   int dev_forward_skb(struct net_device *dev, struct sk_buff *skb);
>   int dev_forward_skb_nomtu(struct net_device *dev, struct sk_buff *skb);
> 

  reply	other threads:[~2021-03-03 22:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-03 15:51 [PATCH bpf 0/3] AF_XDP small fixes Maciej Fijalkowski
2021-03-03 15:51 ` [PATCH bpf 1/3] xsk: remove dangling function declaration from header file Maciej Fijalkowski
2021-03-03 16:33   ` Björn Töpel [this message]
2021-03-03 15:51 ` [PATCH bpf 2/3] samples: bpf: add missing munmap in xdpsock Maciej Fijalkowski
2021-03-03 16:33   ` Björn Töpel
2021-03-03 15:51 ` [PATCH bpf 3/3] libbpf: clear map_info before each bpf_obj_get_info_by_fd Maciej Fijalkowski
2021-03-03 16:33   ` Björn Töpel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dc996d90-ca03-f469-9056-c09ef16dae60@intel.com \
    --to=bjorn.topel@intel.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=john.fastabend@gmail.com \
    --cc=maciej.fijalkowski@intel.com \
    --cc=magnus.karlsson@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).