From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 941EBC433EF for ; Tue, 12 Oct 2021 02:36:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6A62160D42 for ; Tue, 12 Oct 2021 02:36:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231271AbhJLCiX (ORCPT ); Mon, 11 Oct 2021 22:38:23 -0400 Received: from szxga08-in.huawei.com ([45.249.212.255]:25123 "EHLO szxga08-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230362AbhJLCiX (ORCPT ); Mon, 11 Oct 2021 22:38:23 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.55]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4HT09x0t9Qz1DH80; Tue, 12 Oct 2021 10:34:45 +0800 (CST) Received: from dggema721-chm.china.huawei.com (10.3.20.85) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.8; Tue, 12 Oct 2021 10:36:19 +0800 Received: from dggema772-chm.china.huawei.com (10.1.198.214) by dggema721-chm.china.huawei.com (10.3.20.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.8; Tue, 12 Oct 2021 10:36:19 +0800 Received: from dggema772-chm.china.huawei.com ([10.9.128.138]) by dggema772-chm.china.huawei.com ([10.9.128.138]) with mapi id 15.01.2308.008; Tue, 12 Oct 2021 10:36:18 +0800 From: "liujian (CE)" To: John Fastabend , "daniel@iogearbox.net" , "jakub@cloudflare.com" , "lmb@cloudflare.com" , "davem@davemloft.net" , "kuba@kernel.org" , "ast@kernel.org" , "andrii@kernel.org" , "kafai@fb.com" , "songliubraving@fb.com" , "yhs@fb.com" , "kpsingh@kernel.org" , "netdev@vger.kernel.org" , "bpf@vger.kernel.org" , "xiyou.wangcong@gmail.com" Subject: RE: [PATCH v4] skmsg: lose offset info in sk_psock_skb_ingress Thread-Topic: [PATCH v4] skmsg: lose offset info in sk_psock_skb_ingress Thread-Index: AQHXtNafWXeoX8LX90u02UwkM3/EjKu8qsUAgAWaNgCADHS7AA== Date: Tue, 12 Oct 2021 02:36:18 +0000 Message-ID: References: <20210929020642.206454-1-liujian56@huawei.com> <61563ebaf2fe0_6c4e420813@john-XPS-13-9370.notmuch> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.174.176.93] Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogbGl1amlhbiAoQ0UpDQo+ IFNlbnQ6IE1vbmRheSwgT2N0b2JlciA0LCAyMDIxIDEyOjI4IFBNDQo+IFRvOiAnSm9obiBGYXN0 YWJlbmQnIDxqb2huLmZhc3RhYmVuZEBnbWFpbC5jb20+OyBkYW5pZWxAaW9nZWFyYm94Lm5ldDsN Cj4gamFrdWJAY2xvdWRmbGFyZS5jb207IGxtYkBjbG91ZGZsYXJlLmNvbTsgZGF2ZW1AZGF2ZW1s b2Z0Lm5ldDsNCj4ga3ViYUBrZXJuZWwub3JnOyBhc3RAa2VybmVsLm9yZzsgYW5kcmlpQGtlcm5l bC5vcmc7IGthZmFpQGZiLmNvbTsNCj4gc29uZ2xpdWJyYXZpbmdAZmIuY29tOyB5aHNAZmIuY29t OyBrcHNpbmdoQGtlcm5lbC5vcmc7DQo+IG5ldGRldkB2Z2VyLmtlcm5lbC5vcmc7IGJwZkB2Z2Vy Lmtlcm5lbC5vcmc7IHhpeW91Lndhbmdjb25nQGdtYWlsLmNvbQ0KPiBTdWJqZWN0OiBSRTogW1BB VENIIHY0XSBza21zZzogbG9zZSBvZmZzZXQgaW5mbyBpbiBza19wc29ja19za2JfaW5ncmVzcw0K PiANCj4gDQo+IA0KPiA+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4gRnJvbTogSm9o biBGYXN0YWJlbmQgW21haWx0bzpqb2huLmZhc3RhYmVuZEBnbWFpbC5jb21dDQo+ID4gU2VudDog RnJpZGF5LCBPY3RvYmVyIDEsIDIwMjEgNjo0OCBBTQ0KPiA+IFRvOiBsaXVqaWFuIChDRSkgPGxp dWppYW41NkBodWF3ZWkuY29tPjsgam9obi5mYXN0YWJlbmRAZ21haWwuY29tOw0KPiA+IGRhbmll bEBpb2dlYXJib3gubmV0OyBqYWt1YkBjbG91ZGZsYXJlLmNvbTsgbG1iQGNsb3VkZmxhcmUuY29t Ow0KPiA+IGRhdmVtQGRhdmVtbG9mdC5uZXQ7IGt1YmFAa2VybmVsLm9yZzsgYXN0QGtlcm5lbC5v cmc7DQo+ID4gYW5kcmlpQGtlcm5lbC5vcmc7IGthZmFpQGZiLmNvbTsgc29uZ2xpdWJyYXZpbmdA ZmIuY29tOyB5aHNAZmIuY29tOw0KPiA+IGtwc2luZ2hAa2VybmVsLm9yZzsgbmV0ZGV2QHZnZXIu a2VybmVsLm9yZzsgYnBmQHZnZXIua2VybmVsLm9yZzsNCj4gPiB4aXlvdS53YW5nY29uZ0BnbWFp bC5jb20NCj4gPiBDYzogbGl1amlhbiAoQ0UpIDxsaXVqaWFuNTZAaHVhd2VpLmNvbT4NCj4gPiBT dWJqZWN0OiBSRTogW1BBVENIIHY0XSBza21zZzogbG9zZSBvZmZzZXQgaW5mbyBpbg0KPiA+IHNr X3Bzb2NrX3NrYl9pbmdyZXNzDQo+ID4NCj4gPiBMaXUgSmlhbiB3cm90ZToNCj4gPiA+IElmIHNv Y2ttYXAgZW5hYmxlIHN0cnBhcnNlciwgdGhlcmUgYXJlIGxvc2Ugb2Zmc2V0IGluZm8gaW4NCj4g PiA+IHNrX3Bzb2NrX3NrYl9pbmdyZXNzLiBJZiB0aGUgbGVuZ3RoIGRldGVybWluZWQgYnkgcGFy c2VfbXNnIGZ1bmN0aW9uDQo+ID4gPiBpcyBub3Qgc2tiLT5sZW4sIHRoZSBza2Igd2lsbCBiZSBj b252ZXJ0ZWQgdG8gc2tfbXNnIG11bHRpcGxlIHRpbWVzLA0KPiA+ID4gYW5kIHVzZXJzcGFjZSBh cHAgd2lsbCBnZXQgdGhlIGRhdGEgbXVsdGlwbGUgdGltZXMuDQo+ID4gPg0KPiA+ID4gRml4IHRo aXMgYnkgZ2V0IHRoZSBvZmZzZXQgYW5kIGxlbmd0aCBmcm9tIHN0cnBfbXNnLg0KPiA+ID4gQW5k IGFzIENvbmcgc3VnZ2VzdGlvbiwgYWRkIG9uZSBiaXQgaW4gc2tiLT5fc2tfcmVkaXIgdG8gZGlz dGluZ3Vpc2gNCj4gPiA+IGVuYWJsZSBvciBkaXNhYmxlIHN0cnBhcnNlci4NCj4gPiA+DQo+ID4g PiBTaWduZWQtb2ZmLWJ5OiBMaXUgSmlhbiA8bGl1amlhbjU2QGh1YXdlaS5jb20+DQo+ID4gPiAt LS0NCj4gPg0KPiA+IFRoYW5rcy4gUGxlYXNlIGFkZCBGaXhlcyB0YWdzIHNvIHdlIGNhbiB0cmFj ayB0aGVzZSBJJ3ZlIGFkZGVkIGl0IGhlcmUuDQo+ID4NCj4gPiBUaGlzIGhhcyBiZWVuIGJyb2tl biBmcm9tIHRoZSBpbml0aWFsIHBhdGNoZXMgYW5kIGFmdGVyIGEgcXVpY2sgZ2xhbmNlDQo+ID4g SSBzdXNwZWN0IHRoaXMgd2lsbCBuZWVkIG1hbnVhbCBiYWNrcG9ydHMgaWYgd2UgbmVlZCBpdC4g QWxzbyBhbGwgdGhlDQo+ID4gSSB1c2UgYW5kIGFsbCB0aGUgc2VsZnRlc3RzIHNldCBwYXJzZXIg dG8gYSBub3AgYnkgcmV0dXJuaW5nIHNrYi0+bGVuLg0KPiA+DQo+ID4gQ2FuIHlvdSBhbHNvIGNy ZWF0ZSBhIHRlc3Qgc28gd2UgY2FuIGVuc3VyZSB3ZSBkb24ndCBicmVhayB0aGlzIGFnYWluPw0K PiBPa2F5LCBJIHdpbGwgZG8gdGhpcyBhZnRlciB0aGUgaG9saWRheS4NCg0KDQpIaSBKb2huLCAN CkkgY2hlY2tlZCBzZWxmdGVzdHMsIHRoZXJlIGFyZSBoYXZlIG9uZSB0ZXN0IGNhc2UgbmFtZWQg IiB0ZXN0X3R4bXNnX2luZ3Jlc3NfcGFyc2VyIi4NCkJ1dCB3aXRoIHRoaXMgcGF0Y2ggYW5kIGt0 bHMsIHRoZSB0ZXN0IGZhaWxlZCwgdGhpcyBiZWNhdXNlIGt0bHMgcGFyc2VyKHRsc19yZWFkX3Np emUpIHJldHVybiB2YWx1ZSBpcyAyODUgbm90IDI1Ni4NCnRoZSBjYXNlIGxpa2UgdGhpczogDQp0 bHNfc2sxIC0tPiByZWRpcl9zayAtLT4gdGxzX3NrMg0KdGxzX3NrMSBzZW50IG91dCA1MTIgYnl0 ZXMgZGF0YSwgYWZ0ZXIgdGxzIHJlbGF0ZWQgcHJvY2Vzc2luZyByZWRpcl9zayByZWN2ZWQgNTcw IGJ0eWVzIGRhdGEsDQphbmQgcmVkaXJlY3QgNTEyIChza2JfdXNlX3BhcnNlcikgYnl0ZXMgZGF0 YSB0byB0bHNfc2syOyBidXQgdGxzX3NrMiBuZWVkcyAyODUgKiAyIGJ5dGVzIGRhdGEsIHJlY2Vp dmUgdGltZW91dCBvY2N1cnJlZC4NCkkgZml4IHRoaXMgYXMgYmVsb3c6DQotLS0gYS90b29scy90 ZXN0aW5nL3NlbGZ0ZXN0cy9icGYvdGVzdF9zb2NrbWFwLmMNCisrKyBiL3Rvb2xzL3Rlc3Rpbmcv c2VsZnRlc3RzL2JwZi90ZXN0X3NvY2ttYXAuYw0KQEAgLTE2ODAsNiArMTY4MCw4IEBAIHN0YXRp YyB2b2lkIHRlc3RfdHhtc2dfaW5ncmVzc19wYXJzZXIoaW50IGNncnAsIHN0cnVjdCBzb2NrbWFw X29wdGlvbnMgKm9wdCkNCiB7DQogICAgICAgIHR4bXNnX3Bhc3MgPSAxOw0KICAgICAgICBza2Jf dXNlX3BhcnNlciA9IDUxMjsNCisgICAgICAgaWYgKGt0bHMgPT0gMSkNCisgICAgICAgICAgICAg ICBza2JfdXNlX3BhcnNlciA9IDU3MDsNCiAgICAgICAgb3B0LT5pb3ZfbGVuZ3RoID0gMjU2Ow0K ICAgICAgICBvcHQtPmlvdl9jb3VudCA9IDE7DQogICAgICAgIG9wdC0+cmF0ZSA9IDI7DQoNCg0K QW5kIGkgYWRkIG9uZSBuZXcgdGVzdCBhcyBiZWxvdywgaXMgaXQgb2s/DQoNCi0tLSBhL3Rvb2xz L3Rlc3Rpbmcvc2VsZnRlc3RzL2JwZi90ZXN0X3NvY2ttYXAuYw0KKysrIGIvdG9vbHMvdGVzdGlu Zy9zZWxmdGVzdHMvYnBmL3Rlc3Rfc29ja21hcC5jDQpAQCAtMTM5LDYgKzEzOSw3IEBAIHN0cnVj dCBzb2NrbWFwX29wdGlvbnMgew0KICAgICAgICBib29sIHNlbmRwYWdlOw0KICAgICAgICBib29s IGRhdGFfdGVzdDsNCiAgICAgICAgYm9vbCBkcm9wX2V4cGVjdGVkOw0KKyAgICAgICBib29sIGNo ZWNrX3JlY3ZlZF9sZW47DQogICAgICAgIGludCBpb3ZfY291bnQ7DQogICAgICAgIGludCBpb3Zf bGVuZ3RoOw0KICAgICAgICBpbnQgcmF0ZTsNCkBAIC01NTYsOCArNTU3LDEyIEBAIHN0YXRpYyBp bnQgbXNnX2xvb3AoaW50IGZkLCBpbnQgaW92X2NvdW50LCBpbnQgaW92X2xlbmd0aCwgaW50IGNu dCwNCiAgICAgICAgaW50IGVyciwgaSwgZmxhZ3MgPSBNU0dfTk9TSUdOQUw7DQogICAgICAgIGJv b2wgZHJvcCA9IG9wdC0+ZHJvcF9leHBlY3RlZDsNCiAgICAgICAgYm9vbCBkYXRhID0gb3B0LT5k YXRhX3Rlc3Q7DQorICAgICAgIGludCBpb3ZfYWxsb2NfbGVuZ3RoID0gaW92X2xlbmd0aDsNCiAN Ci0gICAgICAgZXJyID0gbXNnX2FsbG9jX2lvdigmbXNnLCBpb3ZfY291bnQsIGlvdl9sZW5ndGgs IGRhdGEsIHR4KTsNCisgICAgICAgaWYgKCF0eCAmJiBvcHQtPmNoZWNrX3JlY3ZlZF9sZW4pDQor ICAgICAgICAgICAgICAgaW92X2FsbG9jX2xlbmd0aCAqPSAyOw0KKw0KKyAgICAgICBlcnIgPSBt c2dfYWxsb2NfaW92KCZtc2csIGlvdl9jb3VudCwgaW92X2FsbG9jX2xlbmd0aCwgZGF0YSwgdHgp Ow0KICAgICAgICBpZiAoZXJyKQ0KICAgICAgICAgICAgICAgIGdvdG8gb3V0X2Vycm5vOw0KICAg ICAgICBpZiAocGVla19mbGFnKSB7DQpAQCAtNjY1LDYgKzY3MCwxMyBAQCBzdGF0aWMgaW50IG1z Z19sb29wKGludCBmZCwgaW50IGlvdl9jb3VudCwgaW50IGlvdl9sZW5ndGgsIGludCBjbnQsDQog DQogICAgICAgICAgICAgICAgICAgICAgICBzLT5ieXRlc19yZWN2ZCArPSByZWN2Ow0KIA0KKyAg ICAgICAgICAgICAgICAgICAgICAgaWYgKG9wdC0+Y2hlY2tfcmVjdmVkX2xlbiAmJiBzLT5ieXRl c19yZWN2ZCA+IHRvdGFsX2J5dGVzKSB7DQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGVycm5vID0gRU1TR1NJWkU7DQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZwcmlu dGYoc3RkZXJyLCAicmVjdiBmYWlsZWQoKSwgYnl0ZXNfcmVjdmQ6JXpkLCB0b3RhbF9ieXRlczol ZlxuIiwNCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHMt PmJ5dGVzX3JlY3ZkLCB0b3RhbF9ieXRlcyk7DQorICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGdvdG8gb3V0X2Vycm5vOw0KKyAgICAgICAgICAgICAgICAgICAgICAgfQ0KKw0KICAgICAg ICAgICAgICAgICAgICAgICAgaWYgKGRhdGEpIHsNCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgaW50IGNodW5rX3N6ID0gb3B0LT5zZW5kcGFnZSA/DQogICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpb3ZfbGVuZ3RoICogY250IDoNCkBAIC03NDQs NyArNzU2LDggQEAgc3RhdGljIGludCBzZW5kbXNnX3Rlc3Qoc3RydWN0IHNvY2ttYXBfb3B0aW9u cyAqb3B0KQ0KIA0KICAgICAgICByeHBpZCA9IGZvcmsoKTsNCiAgICAgICAgaWYgKHJ4cGlkID09 IDApIHsNCi0gICAgICAgICAgICAgICBpb3ZfYnVmIC09ICh0eG1zZ19wb3AgLSB0eG1zZ19zdGFy dF9wb3AgKyAxKTsNCisgICAgICAgICAgICAgICBpZiAodHhtc2dfcG9wIHx8IHR4bXNnX3N0YXJ0 X3BvcCkNCisgICAgICAgICAgICAgICAgICAgICAgIGlvdl9idWYgLT0gKHR4bXNnX3BvcCAtIHR4 bXNnX3N0YXJ0X3BvcCArIDEpOw0KICAgICAgICAgICAgICAgIGlmIChvcHQtPmRyb3BfZXhwZWN0 ZWQgfHwgdHhtc2dfa3Rsc19za2JfZHJvcCkNCiAgICAgICAgICAgICAgICAgICAgICAgIF9leGl0 KDApOw0KIA0KQEAgLTE2ODgsNiArMTcwMSwxOSBAQCBzdGF0aWMgdm9pZCB0ZXN0X3R4bXNnX2lu Z3Jlc3NfcGFyc2VyKGludCBjZ3JwLCBzdHJ1Y3Qgc29ja21hcF9vcHRpb25zICpvcHQpDQogICAg ICAgIHRlc3RfZXhlYyhjZ3JwLCBvcHQpOw0KIH0NCiANCitzdGF0aWMgdm9pZCB0ZXN0X3R4bXNn X2luZ3Jlc3NfcGFyc2VyMihpbnQgY2dycCwgc3RydWN0IHNvY2ttYXBfb3B0aW9ucyAqb3B0KQ0K K3sNCisgICAgICAgaWYgKGt0bHMgPT0gMSkNCisgICAgICAgICAgICAgICByZXR1cm47DQorICAg ICAgIHNrYl91c2VfcGFyc2VyID0gMTA7DQorICAgICAgIG9wdC0+aW92X2xlbmd0aCA9IDIwOw0K KyAgICAgICBvcHQtPmlvdl9jb3VudCA9IDE7DQorICAgICAgIG9wdC0+cmF0ZSA9IDE7DQorICAg ICAgIG9wdC0+Y2hlY2tfcmVjdmVkX2xlbiA9IHRydWU7DQorICAgICAgIHRlc3RfZXhlYyhjZ3Jw LCBvcHQpOw0KKyAgICAgICBvcHQtPmNoZWNrX3JlY3ZlZF9sZW4gPSBmYWxzZTsNCit9DQorDQog Y2hhciAqbWFwX25hbWVzW10gPSB7DQogICAgICAgICJzb2NrX21hcCIsDQogICAgICAgICJzb2Nr X21hcF90eG1zZyIsDQpAQCAtMTc4Niw3ICsxODEyLDggQEAgc3RydWN0IF90ZXN0IHRlc3RbXSA9 IHsNCiAgICAgICAgeyJ0eG1zZyB0ZXN0IHB1bGwtZGF0YSIsIHRlc3RfdHhtc2dfcHVsbH0sDQog ICAgICAgIHsidHhtc2cgdGVzdCBwb3AtZGF0YSIsIHRlc3RfdHhtc2dfcG9wfSwNCiAgICAgICAg eyJ0eG1zZyB0ZXN0IHB1c2gvcG9wIGRhdGEiLCB0ZXN0X3R4bXNnX3B1c2hfcG9wfSwNCi0gICAg ICAgeyJ0eG1zZyB0ZXh0IGluZ3Jlc3MgcGFyc2VyIiwgdGVzdF90eG1zZ19pbmdyZXNzX3BhcnNl cn0sDQorICAgICAgIHsidHhtc2cgdGVzdCBpbmdyZXNzIHBhcnNlciIsIHRlc3RfdHhtc2dfaW5n cmVzc19wYXJzZXJ9LA0KKyAgICAgICB7InR4bXNnIHRlc3QgaW5ncmVzcyBwYXJzZXIyIiwgdGVz dF90eG1zZ19pbmdyZXNzX3BhcnNlcjJ9LA0KIH07DQoNCj4gPg0KPiA+IEZpeGVzOiA2MDQzMjZi NDFhNmZiICgiYnBmLCBzb2NrbWFwOiBjb252ZXJ0IHRvIGdlbmVyaWMgc2tfbXNnDQo+ID4gaW50 ZXJmYWNlIikNCj4gPiBBY2tlZC1ieTogSm9obiBGYXN0YWJlbmQgPGpvaG4uZmFzdGFiZW5kQGdt YWlsLmNvbT4NCj4gVGhhbmsgeW91IGZvciByZXZpZXdpbmcgdGhpcyBwYXRjaCBhZ2Fpbi4NCg==