From: Alexei Starovoitov <ast@fb.com>
To: Andrii Nakryiko <andriin@fb.com>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"daniel@iogearbox.net" <daniel@iogearbox.net>
Cc: "andrii.nakryiko@gmail.com" <andrii.nakryiko@gmail.com>,
Kernel Team <Kernel-team@fb.com>
Subject: Re: [PATCH v3 bpf-next 2/4] libbpf: support libbpf-provided extern variables
Date: Sat, 14 Dec 2019 00:20:08 +0000 [thread overview]
Message-ID: <e612995b-ee80-5d22-512c-dfe700c97865@fb.com> (raw)
In-Reply-To: <20191213235144.3063354-3-andriin@fb.com>
On 12/13/19 3:51 PM, Andrii Nakryiko wrote:
> static int
> bpf_object__init_internal_map(struct bpf_object *obj, enum libbpf_map_type type,
> - int sec_idx, Elf_Data *data)
> + int sec_idx, void *data, size_t data_sz)
the previous patch set did:
bpf_object__init_internal_map(struct bpf_object *obj, enum
libbpf_map_type type,
- int sec_idx, Elf_Data *data, void **data_buff)
+ int sec_idx, Elf_Data *data)
and now this patch set refactors it again from Elf_Data into
two individual arguments.
Could you do this right away in the previous set and avoid this churn?
Not a strong opinion though.
Just odd to see the function being changed back to back.
Thankfully that's internal in .c file.
next prev parent reply other threads:[~2019-12-14 0:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-13 23:51 [PATCH v3 bpf-next 0/4] Add libbpf-provided extern variables support Andrii Nakryiko
2019-12-13 23:51 ` [PATCH v3 bpf-next 1/4] libbpf: extract internal map names into constants Andrii Nakryiko
2019-12-13 23:51 ` [PATCH v3 bpf-next 2/4] libbpf: support libbpf-provided extern variables Andrii Nakryiko
2019-12-14 0:20 ` Alexei Starovoitov [this message]
2019-12-14 1:20 ` Andrii Nakryiko
2019-12-13 23:51 ` [PATCH v3 bpf-next 3/4] bpftool: generate externs datasec in BPF skeleton Andrii Nakryiko
2019-12-13 23:51 ` [PATCH v3 bpf-next 4/4] selftests/bpf: add tests for libbpf-provided externs Andrii Nakryiko
2019-12-14 0:22 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e612995b-ee80-5d22-512c-dfe700c97865@fb.com \
--to=ast@fb.com \
--cc=Kernel-team@fb.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).