* [PATCH] selftests/bpf: signedness bug in enable_all_controllers()
@ 2019-06-13 7:00 Dan Carpenter
2019-06-13 16:58 ` Andrii Nakryiko
2019-06-14 23:20 ` Daniel Borkmann
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2019-06-13 7:00 UTC (permalink / raw)
To: Shuah Khan, Roman Gushchin
Cc: Alexei Starovoitov, Daniel Borkmann, Martin KaFai Lau, Song Liu,
Yonghong Song, linux-kselftest, bpf, kernel-janitors
The "len" variable needs to be signed for the error handling to work
properly.
Fixes: 596092ef8bea ("selftests/bpf: enable all available cgroup v2 controllers")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
tools/testing/selftests/bpf/cgroup_helpers.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/bpf/cgroup_helpers.c b/tools/testing/selftests/bpf/cgroup_helpers.c
index 0d89f0396be4..e95c33e333a4 100644
--- a/tools/testing/selftests/bpf/cgroup_helpers.c
+++ b/tools/testing/selftests/bpf/cgroup_helpers.c
@@ -47,7 +47,7 @@ int enable_all_controllers(char *cgroup_path)
char buf[PATH_MAX];
char *c, *c2;
int fd, cfd;
- size_t len;
+ ssize_t len;
snprintf(path, sizeof(path), "%s/cgroup.controllers", cgroup_path);
fd = open(path, O_RDONLY);
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] selftests/bpf: signedness bug in enable_all_controllers()
2019-06-13 7:00 [PATCH] selftests/bpf: signedness bug in enable_all_controllers() Dan Carpenter
@ 2019-06-13 16:58 ` Andrii Nakryiko
2019-06-14 23:20 ` Daniel Borkmann
1 sibling, 0 replies; 3+ messages in thread
From: Andrii Nakryiko @ 2019-06-13 16:58 UTC (permalink / raw)
To: Dan Carpenter
Cc: Shuah Khan, Roman Gushchin, Alexei Starovoitov, Daniel Borkmann,
Martin KaFai Lau, Song Liu, Yonghong Song, linux-kselftest, bpf,
kernel-janitors
On Thu, Jun 13, 2019 at 9:40 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> The "len" variable needs to be signed for the error handling to work
> properly.
>
> Fixes: 596092ef8bea ("selftests/bpf: enable all available cgroup v2 controllers")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
Thanks for the fix!
Acked-by: Andrii Nakryiko <andriin@fb.com>
> tools/testing/selftests/bpf/cgroup_helpers.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/cgroup_helpers.c b/tools/testing/selftests/bpf/cgroup_helpers.c
> index 0d89f0396be4..e95c33e333a4 100644
> --- a/tools/testing/selftests/bpf/cgroup_helpers.c
> +++ b/tools/testing/selftests/bpf/cgroup_helpers.c
> @@ -47,7 +47,7 @@ int enable_all_controllers(char *cgroup_path)
> char buf[PATH_MAX];
> char *c, *c2;
> int fd, cfd;
> - size_t len;
> + ssize_t len;
>
> snprintf(path, sizeof(path), "%s/cgroup.controllers", cgroup_path);
> fd = open(path, O_RDONLY);
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] selftests/bpf: signedness bug in enable_all_controllers()
2019-06-13 7:00 [PATCH] selftests/bpf: signedness bug in enable_all_controllers() Dan Carpenter
2019-06-13 16:58 ` Andrii Nakryiko
@ 2019-06-14 23:20 ` Daniel Borkmann
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Borkmann @ 2019-06-14 23:20 UTC (permalink / raw)
To: Dan Carpenter, Shuah Khan, Roman Gushchin
Cc: Alexei Starovoitov, Martin KaFai Lau, Song Liu, Yonghong Song,
linux-kselftest, bpf, kernel-janitors
On 06/13/2019 09:00 AM, Dan Carpenter wrote:
> The "len" variable needs to be signed for the error handling to work
> properly.
>
> Fixes: 596092ef8bea ("selftests/bpf: enable all available cgroup v2 controllers")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-14 23:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-13 7:00 [PATCH] selftests/bpf: signedness bug in enable_all_controllers() Dan Carpenter
2019-06-13 16:58 ` Andrii Nakryiko
2019-06-14 23:20 ` Daniel Borkmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).