bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ilya Leoshkevich <iii@linux.ibm.com>
To: Tiezhu Yang <yangtiezhu@loongson.cn>,
	Heiko Carstens <hca@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Andrii Nakryiko <andrii@kernel.org>,
	Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
	Yonghong Song <yhs@fb.com>,
	John Fastabend <john.fastabend@gmail.com>,
	KP Singh <kpsingh@kernel.org>
Cc: Yauheni Kaliuta <yauheni.kaliuta@redhat.com>,
	netdev@vger.kernel.org, bpf@vger.kernel.org,
	linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
	Xuefeng Li <lixuefeng@loongson.cn>
Subject: Re: [PATCH RESEND bpf] bpf, s390: Fix potential memory leak about jit_data
Date: Mon, 27 Sep 2021 13:33:10 +0200	[thread overview]
Message-ID: <e9665315bc2f244d50d026863476e72e3d9b8067.camel@linux.ibm.com> (raw)
In-Reply-To: <1632726374-7154-1-git-send-email-yangtiezhu@loongson.cn>

On Mon, 2021-09-27 at 15:06 +0800, Tiezhu Yang wrote:
> Make sure to free jit_data through kfree() in the error path.
> 
> Fixes: 1c8f9b91c456 ("bpf: s390: add JIT support for multi-function
> programs")
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
> 
> RESEND due to the following reason:
> [Can not connect to recipient's server because of unstable
> network or firewall filter. rcpt handle timeout, last handle
> info: Can not connect to vger.kernel.org]
> 
>  arch/s390/net/bpf_jit_comp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Nice catch, thanks!

Acked-by: Ilya Leoshkevich <iii@linux.ibm.com>


       reply	other threads:[~2021-09-27 11:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1632726374-7154-1-git-send-email-yangtiezhu@loongson.cn>
2021-09-27 11:33 ` Ilya Leoshkevich [this message]
2021-09-27 15:26   ` [PATCH RESEND bpf] bpf, s390: Fix potential memory leak about jit_data Daniel Borkmann
2021-09-27 15:58     ` Christian Borntraeger
2021-09-27 16:13       ` Konstantin Ryabitsev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e9665315bc2f244d50d026863476e72e3d9b8067.camel@linux.ibm.com \
    --to=iii@linux.ibm.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=borntraeger@de.ibm.com \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=john.fastabend@gmail.com \
    --cc=kafai@fb.com \
    --cc=kpsingh@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=lixuefeng@loongson.cn \
    --cc=netdev@vger.kernel.org \
    --cc=songliubraving@fb.com \
    --cc=yangtiezhu@loongson.cn \
    --cc=yauheni.kaliuta@redhat.com \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).