From: Shuah Khan <skhan@linuxfoundation.org>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: ast@kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com,
netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] tools: bpf: Use !building_out_of_srctree to determine srctree
Date: Mon, 30 Sep 2019 08:16:55 -0600 [thread overview]
Message-ID: <ea108769-1b3e-42f8-de9c-50b4a563be57@linuxfoundation.org> (raw)
In-Reply-To: <20190930085815.GA7249@pc-66.home>
On 9/30/19 2:58 AM, Daniel Borkmann wrote:
> On Thu, Sep 26, 2019 at 07:13:44PM -0600, Shuah Khan wrote:
>> make TARGETS=bpf kselftest fails with:
>>
>> Makefile:127: tools/build/Makefile.include: No such file or directory
>>
>> When the bpf tool make is invoked from tools Makefile, srctree is
>> cleared and the current logic check for srctree equals to empty
>> string to determine srctree location from CURDIR.
>>
>> When the build in invoked from selftests/bpf Makefile, the srctree
>> is set to "." and the same logic used for srctree equals to empty is
>> needed to determine srctree.
>>
>> Check building_out_of_srctree undefined as the condition for both
>> cases to fix "make TARGETS=bpf kselftest" build failure.
>>
>> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
>
> Applied, thanks!
>
Hi Daniel!
Is the tree the patch went into included in the linux-next?
thanks,
-- Shuah
next prev parent reply other threads:[~2019-09-30 14:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-27 1:13 [PATCH] tools: bpf: Use !building_out_of_srctree to determine srctree Shuah Khan
2019-09-27 18:44 ` Song Liu
2019-09-27 19:03 ` Shuah Khan
2019-09-27 21:15 ` Song Liu
2019-09-30 8:58 ` Daniel Borkmann
2019-09-30 14:16 ` Shuah Khan [this message]
2019-09-30 18:23 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea108769-1b3e-42f8-de9c-50b4a563be57@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kafai@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).