Re: [PATCH] perf tools: Fix potential memory leak in perf events parser

From: Markus Elfring <Markus.Elfring@web.de>
To: Chen Wandun <chenwandun@huawei.com>,
	netdev@vger.kernel.org, bpf@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Yonghong Song <yhs@fb.com>,
	Song Liu <songliubraving@fb.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Andrii Nakryiko <andriin@fb.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Cheng Jian <cj.chengjian@huawei.com>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Ian Rogers <irogers@google.com>, Ingo Molnar <mingo@redhat.com>,
	Jiri Olsa <jolsa@redhat.com>,
	John Fastabend <john.fastabend@gmail.com>,
	Leo Yan <leo.yan@linaro.org>, Mark Rutland <mark.rutland@arm.com>,
	Martin KaFai Lau <kafai@fb.com>,
	Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH] perf tools: Fix potential memory leak in perf events parser
Date: Thu, 11 Jun 2020 15:17:17 +0200	[thread overview]
Message-ID: <ea548157-5cb0-ffa7-9bd5-ff3f9c66b1de@web.de> (raw)

> Fix potential memory leak in function parse_events_term__sym_hw()
> and parse_events_term__clone().

Would you like to add the tag “Fixes” to the commit message?

…
> +++ b/tools/perf/util/parse-events.c
…
> @@ -2957,9 +2958,20 @@  int parse_events_term__sym_hw(struct parse_events_term **term,
>  	sym = &event_symbols_hw[idx];
>
>  	str = strdup(sym->symbol);
> -	if (!str)
> +	if (!str) {
> +		if (!config)
> +			free(temp.config);
>  		return -ENOMEM;
> -	return new_term(term, &temp, str, 0);
> +	}
> +
> +	ret = new_term(term, &temp, str, 0);
> +	if (ret < 0) {
> +		free(str);
> +		if (!config)
> +			free(temp.config);
> +	}
> +
> +	return ret;
>  }
…

How do you think about to add jump targets for a bit of
common exception handling code in these function implementations?

Regards,
Markus