From: Christoph Lameter <cl@gentwo.de>
To: Yafang Shao <laoar.shao@gmail.com>
Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
kafai@fb.com, songliubraving@fb.com, yhs@fb.com,
john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com,
haoluo@google.com, jolsa@kernel.org, tj@kernel.org,
dennis@kernel.org, akpm@linux-foundation.org, penberg@kernel.org,
rientjes@google.com, iamjoonsoo.kim@lge.com,
roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, vbabka@suse.cz,
urezki@gmail.com, linux-mm@kvack.org, bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next 2/7] mm: percpu: introduce percpu_size()
Date: Thu, 2 Feb 2023 15:32:54 +0100 (CET) [thread overview]
Message-ID: <f18a3e-335c-ef3e-b572-73bd651138e4@gentwo.de> (raw)
In-Reply-To: <20230202014158.19616-3-laoar.shao@gmail.com>
On Thu, 2 Feb 2023, Yafang Shao wrote:
> + bits = end - bit_off;
> + size = bits * PCPU_MIN_ALLOC_SIZE;
> +
> + return pcpu_obj_full_size(size);
Dont you have to multiply by the number of online cpus? The per cpu area
are duplicated for those.
next prev parent reply other threads:[~2023-02-02 14:39 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-02 1:41 [PATCH bpf-next 0/7] bpf, mm: bpf memory usage Yafang Shao
2023-02-02 1:41 ` [PATCH bpf-next 1/7] mm: percpu: fix incorrect size in pcpu_obj_full_size() Yafang Shao
2023-02-02 1:41 ` [PATCH bpf-next 2/7] mm: percpu: introduce percpu_size() Yafang Shao
2023-02-02 14:32 ` Christoph Lameter [this message]
2023-02-02 15:01 ` Yafang Shao
2023-02-02 1:41 ` [PATCH bpf-next 3/7] mm: vmalloc: introduce vsize() Yafang Shao
2023-02-02 10:23 ` Christoph Hellwig
2023-02-02 14:10 ` Yafang Shao
2023-02-02 1:41 ` [PATCH bpf-next 4/7] mm: util: introduce kvsize() Yafang Shao
2023-02-02 1:41 ` [PATCH bpf-next 5/7] bpf: add new map ops ->map_mem_usage Yafang Shao
2023-02-02 1:41 ` [PATCH bpf-next 6/7] bpf: introduce bpf_mem_alloc_size() Yafang Shao
2023-02-02 4:53 ` kernel test robot
2023-02-02 14:11 ` Yafang Shao
2023-02-02 1:41 ` [PATCH bpf-next 7/7] bpf: hashtab memory usage Yafang Shao
2023-02-04 2:01 ` John Fastabend
2023-02-05 3:55 ` Yafang Shao
2023-02-08 1:56 ` Alexei Starovoitov
2023-02-08 3:33 ` Yafang Shao
2023-02-08 4:29 ` Alexei Starovoitov
2023-02-08 14:22 ` Yafang Shao
2023-02-05 22:14 ` Cong Wang
2023-02-06 11:52 ` Yafang Shao
2023-02-04 2:15 ` [PATCH bpf-next 0/7] bpf, mm: bpf " John Fastabend
2023-02-05 4:03 ` Yafang Shao
2023-02-07 0:53 ` Ho-Ren Chuang
[not found] ` <CAOfppAUgB1qtFQfSb7WnGTJ+0fP2NL_T9EJYHgwQyW0mx4vnXA@mail.gmail.com>
2023-02-07 7:02 ` Yafang Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f18a3e-335c-ef3e-b572-73bd651138e4@gentwo.de \
--to=cl@gentwo.de \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=dennis@kernel.org \
--cc=haoluo@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=laoar.shao@gmail.com \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=sdf@google.com \
--cc=songliubraving@fb.com \
--cc=tj@kernel.org \
--cc=urezki@gmail.com \
--cc=vbabka@suse.cz \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).