From: Andreas Steinmetz <ast@domdv.de>
To: nicolas.dichtel@6wind.com, netdev@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [RFC][PATCH kernel_bpf] honor CAP_NET_ADMIN for BPF_PROG_LOAD
Date: Wed, 05 Jun 2019 12:59:48 +0200 [thread overview]
Message-ID: <f3b59d9ac00eec18bc62a75f2dd6dbba48da0b35.camel@domdv.de> (raw)
In-Reply-To: <1188fe85-d627-89d1-d56b-91011166f9c7@6wind.com>
On Mon, 2019-06-03 at 19:12 +0200, Nicolas Dichtel wrote:
> It makes sense to me.
> Do you plan to submit it formally?
>
> Looking a bit more at this topic, I see that most part of the bpf
> code uses
> capable(CAP_NET_ADMIN). I don't see why we cannot use
> ns_capable(CAP_NET_ADMIN).
If there is a change for this to get accepted, sure, I'm willing to
submit this formally (need some advice, though).
As for capable vs. ns_capable, this is a bit above my knowledge of
kernel internals.
Regards,
Andreas
next prev parent reply other threads:[~2019-06-05 11:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 16:53 [RFC][PATCH kernel_bpf] honor CAP_NET_ADMIN for BPF_PROG_LOAD Andreas Steinmetz
2019-05-28 21:04 ` Song Liu
2019-06-05 10:56 ` Andreas Steinmetz
2019-06-03 17:12 ` Nicolas Dichtel
2019-06-05 10:59 ` Andreas Steinmetz [this message]
2019-06-05 11:51 ` Nicolas Dichtel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3b59d9ac00eec18bc62a75f2dd6dbba48da0b35.camel@domdv.de \
--to=ast@domdv.de \
--cc=bpf@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).