From: Eric Dumazet <eric.dumazet@gmail.com>
To: Lorenz Bauer <lmb@cloudflare.com>, Eric Dumazet <eric.dumazet@gmail.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>,
Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>, bpf <bpf@vger.kernel.org>,
Networking <netdev@vger.kernel.org>,
kernel-team <kernel-team@cloudflare.com>
Subject: Re: [PATCH bpf-next v2 1/4] net: add SO_NETNS_COOKIE socket option
Date: Fri, 19 Feb 2021 16:32:32 +0100 [thread overview]
Message-ID: <f4ac5b02-3821-787c-6da9-50aa44d2847b@gmail.com> (raw)
In-Reply-To: <CACAyw9_kY9fPdC5DLz4GKiBR8B4mCCnknB2xY1DSKYwkridgFQ@mail.gmail.com>
On 2/19/21 1:23 PM, Lorenz Bauer wrote:
> On Fri, 19 Feb 2021 at 11:49, Eric Dumazet <eric.dumazet@gmail.com> wrote:
>>
>>> + case SO_NETNS_COOKIE:
>>> + lv = sizeof(u64);
>>> + if (len < lv)
>>> + return -EINVAL;
>>
>> if (len != lv)
>> return -EINVAL;
>>
>> (There is no reason to support bigger value before at least hundred years)
>
> Sorry that was copy pasta from SO_COOKIE which uses the same check. I'll
> change it to your suggestion. Want me to fix SO_COOKIE as well?
Unfortunately it is too late for SO_COOKIE
Some applications might use len = 256, and just look at what the kernel
gives back.
Better be strict at the time a feature is added, instead of having
to maintain legacy stuff.
next prev parent reply other threads:[~2021-02-19 15:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 9:51 [PATCH bpf-next v2 0/4] Expose network namespace cookies to user space Lorenz Bauer
2021-02-19 9:51 ` [PATCH bpf-next v2 1/4] net: add SO_NETNS_COOKIE socket option Lorenz Bauer
2021-02-19 11:49 ` Eric Dumazet
2021-02-19 12:23 ` Lorenz Bauer
2021-02-19 15:32 ` Eric Dumazet [this message]
2021-02-19 9:51 ` [PATCH bpf-next v2 2/4] nsfs: add an ioctl to discover the network namespace cookie Lorenz Bauer
2021-02-19 9:51 ` [PATCH bpf-next v2 3/4] tools/testing: add test for NS_GET_COOKIE Lorenz Bauer
2021-02-19 9:51 ` [PATCH bpf-next v2 4/4] tools/testing: add a selftest for SO_NETNS_COOKIE Lorenz Bauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4ac5b02-3821-787c-6da9-50aa44d2847b@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@cloudflare.com \
--cc=lmb@cloudflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).