From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBE4EC27C76 for ; Sun, 22 Jan 2023 11:54:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229992AbjAVLyW (ORCPT ); Sun, 22 Jan 2023 06:54:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229566AbjAVLyU (ORCPT ); Sun, 22 Jan 2023 06:54:20 -0500 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5BB79EE8 for ; Sun, 22 Jan 2023 03:54:18 -0800 (PST) Received: by mail-wr1-x42f.google.com with SMTP id e3so8445857wru.13 for ; Sun, 22 Jan 2023 03:54:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SufkmAjwbNPzx+QZI0to5Uf48TUW+IZPLNjbNqCZpfI=; b=agLJLLTVda4vzbo+pBm1nc5uVfx6hrGX4HQkgIojkD/1cyQqIJv/dW6ozQQZxh9acO 0GIArSOuUVD0jo2VEYapOBIRUz5rU0ickudZecB/MxBJcXysLhAmHyMc4oBteDTIVZMP gWC6imLaRflwc3jb3Je1wClPZlQKNp6xyUYD3v0X33auCHxc+qD/ZA/jJBtt4IwIx7rF gSScl4TsJrIet9k0uAS97cSICY1543XxKH25XG+KtqbOQ1xwZB+O3y7k0SPxq0AYdW3y nsmpTPaZyS0wpbBSnQCu92eqyFbTR8SK3YHX60WCqpdfFl3mYAplQ0n+AxAh2HMkH8Q8 TEWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SufkmAjwbNPzx+QZI0to5Uf48TUW+IZPLNjbNqCZpfI=; b=FEqNIrsKWac59wOJKeyGaPo2B+dq/virO4Ne9/VVXark2Y8SQNugwxPmzjtEUYFhLJ MByNRK7qAIT6tnXIXEoGjiCAMNojU+9+m8gecYSUN7S9DQtZvwMSuEcnooiWuB35vUhp h5eJFfZglCeboyx8H7sIht8qKSI/fIkCM4CpcFBch7hEQE/Tu+PmaLV2K6U+YKtzl/ge lrQT/+g/FOnuZRhiEt4uJdsS3y4f7KyhyLgpesXXoUTDHDUYC/a5wykc2/xr5O3m9aUv APGgAbPMYbY6PPwRq55ybU56DHNQoeAPnBWi8A5rPk4Gq0Dm8V3pHdIE5klvvrbr6aTL maOA== X-Gm-Message-State: AFqh2kqu/hGT2sZ3xvMS+URjHXLCM4IQlRZBGHtZv9FCwERnb7D8FQiT XBaZJxMYDaMbbQEPDHPJUlwDtg== X-Google-Smtp-Source: AMrXdXt21M3CsHbnhN4nC75KtRaK9snE7H1KnN8u8SuCQjR3lZXo7Zes1x4/j1347YU7bM+ZYlALNg== X-Received: by 2002:adf:e9d2:0:b0:2bd:e6f5:5122 with SMTP id l18-20020adfe9d2000000b002bde6f55122mr17418436wrn.65.1674388457426; Sun, 22 Jan 2023 03:54:17 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id ba9-20020a0560001c0900b002b57bae7174sm2174746wrb.5.2023.01.22.03.54.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 Jan 2023 03:54:16 -0800 (PST) Message-ID: Date: Sun, 22 Jan 2023 12:54:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [RFC PATCH v2 30/31] kvx: Add power controller driver Content-Language: en-US To: Yann Sionneau , Arnd Bergmann , Jonathan Corbet , Thomas Gleixner , Marc Zyngier , Rob Herring , Krzysztof Kozlowski , Will Deacon , Peter Zijlstra , Boqun Feng , Mark Rutland , Eric Biederman , Kees Cook , Oleg Nesterov , Ingo Molnar , Waiman Long , "Aneesh Kumar K.V" , Andrew Morton , Nick Piggin , Paul Moore , Eric Paris , Christian Brauner , Paul Walmsley , Palmer Dabbelt , Albert Ou , Jules Maselbas , Guillaume Thouvenin , Clement Leger , Vincent Chardon , =?UTF-8?Q?Marc_Poulhi=c3=a8s?= , Julian Vetter , Samuel Jones , Ashley Lesdalons , Thomas Costis , Marius Gligor , Jonathan Borne , Julien Villette , Luc Michel , Louis Morhet , Julien Hascoet , Jean-Christophe Pince , Guillaume Missonnier , Alex Michon , Huacai Chen , WANG Xuerui , Shaokun Zhang , John Garry , Guangbin Huang , Bharat Bhushan , Bibo Mao , Atish Patra , "Jason A. Donenfeld" , Qi Liu , Jiaxun Yang , Catalin Marinas , Mark Brown , Janosch Frank , Alexey Dobriyan Cc: Benjamin Mugnier , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-audit@redhat.com, linux-riscv@lists.infradead.org, bpf@vger.kernel.org References: <20230120141002.2442-1-ysionneau@kalray.eu> <20230120141002.2442-31-ysionneau@kalray.eu> From: Krzysztof Kozlowski In-Reply-To: <20230120141002.2442-31-ysionneau@kalray.eu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On 20/01/2023 15:10, Yann Sionneau wrote: > From: Jules Maselbas > > The Power Controller (pwr-ctrl) control cores reset and wake-up > procedure. > + > +static struct device_node * __init get_pwr_ctrl_node(void) > +{ > + const phandle *ph; > + struct device_node *cpu; > + struct device_node *node; > + > + cpu = of_get_cpu_node(raw_smp_processor_id(), NULL); > + if (!cpu) { > + pr_err("Failed to get CPU node\n"); > + return NULL; > + } > + > + ph = of_get_property(cpu, "power-controller", NULL); > + if (!ph) { > + pr_err("Failed to get power-controller phandle\n"); > + return NULL; > + } > + > + node = of_find_node_by_phandle(be32_to_cpup(ph)); > + if (!node) { > + pr_err("Failed to get power-controller node\n"); > + return NULL; > + } > + > + return node; > +} > + > +int __init kvx_pwr_ctrl_probe(void) > +{ > + struct device_node *ctrl; > + > + ctrl = get_pwr_ctrl_node(); > + if (!ctrl) { > + pr_err("Failed to get power controller node\n"); > + return -EINVAL; > + } > + > + if (!of_device_is_compatible(ctrl, "kalray,kvx-pwr-ctrl")) { > + pr_err("Failed to get power controller node\n"); No. Drivers go to drivers, not to arch directory. This should be a proper driver instead of some fake stub doing its own driver matching. You need to rework this. Best regards, Krzysztof