From: Quentin Monnet <quentin@isovalent.com>
To: grantseltzer <grantseltzer@gmail.com>,
andrii@kernel.org, daniel@iogearbox.net, kafai@fb.com,
songliubraving@fb.com, john.fastabend@gmail.com,
kpsingh@kernel.org
Cc: irogers@google.com, yhs@fb.com, tklauser@distanz.ch,
netdev@vger.kernel.org, mrostecki@opensuse.org, ast@kernel.org,
bpf@vger.kernel.org
Subject: Re: [PATCH v3 bpf-next] Add CONFIG_DEBUG_INFO_BTF check to bpftool feature command
Date: Mon, 22 Feb 2021 16:02:48 +0000 [thread overview]
Message-ID: <fb6b0a82-5a60-0574-6557-93aaa03fdbf1@isovalent.com> (raw)
In-Reply-To: <20210220171307.128382-1-grantseltzer@gmail.com>
2021-02-20 17:13 UTC+0000 ~ grantseltzer <grantseltzer@gmail.com>
> This adds the CONFIG_DEBUG_INFO_BTF kernel compile option to output of
> the bpftool feature command. This is relevant for developers that want
> to use libbpf to account for data structure definition differences
> between kernels.
>
> Signed-off-by: grantseltzer <grantseltzer@gmail.com>
> ---
> tools/bpf/bpftool/feature.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/bpf/bpftool/feature.c b/tools/bpf/bpftool/feature.c
> index 359960a8f..b90cc6832 100644
> --- a/tools/bpf/bpftool/feature.c
> +++ b/tools/bpf/bpftool/feature.c
> @@ -336,6 +336,8 @@ static void probe_kernel_image_config(const char *define_prefix)
> { "CONFIG_BPF_JIT", },
> /* Avoid compiling eBPF interpreter (use JIT only) */
> { "CONFIG_BPF_JIT_ALWAYS_ON", },
> + /* Kernel BTF debug information available */
> + { "CONFIG_DEBUG_INFO_BTF", },
>
> /* cgroups */
> { "CONFIG_CGROUPS", },
>
Thanks for the change!
Reviewed-by: Quentin Monnet <quentin@isovalent.com>
(Note: the date of the email is not correct, but I discussed offline
with Grant and this is now sorted out for future submissions.)
Quentin
next prev parent reply other threads:[~2021-02-22 16:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-20 17:13 [PATCH v3 bpf-next] Add CONFIG_DEBUG_INFO_BTF check to bpftool feature command grantseltzer
2021-02-22 16:02 ` Quentin Monnet [this message]
2021-02-22 19:05 ` Martin KaFai Lau
2021-02-22 19:22 ` Andrii Nakryiko
2021-02-22 20:05 ` Grant Seltzer Richman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb6b0a82-5a60-0574-6557-93aaa03fdbf1@isovalent.com \
--to=quentin@isovalent.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=grantseltzer@gmail.com \
--cc=irogers@google.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=mrostecki@opensuse.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=tklauser@distanz.ch \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).