From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12C93C388F3 for ; Mon, 30 Sep 2019 08:19:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DC9DE2190F for ; Mon, 30 Sep 2019 08:19:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729232AbfI3ITt (ORCPT ); Mon, 30 Sep 2019 04:19:49 -0400 Received: from 3.mo1.mail-out.ovh.net ([46.105.60.232]:49405 "EHLO 3.mo1.mail-out.ovh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729981AbfI3ITq (ORCPT ); Mon, 30 Sep 2019 04:19:46 -0400 X-Greylist: delayed 1802 seconds by postgrey-1.27 at vger.kernel.org; Mon, 30 Sep 2019 04:19:43 EDT Received: from player759.ha.ovh.net (unknown [10.109.159.68]) by mo1.mail-out.ovh.net (Postfix) with ESMTP id 67F87191A79 for ; Mon, 30 Sep 2019 09:41:22 +0200 (CEST) Received: from RCM-web7.webmail.mail.ovh.net (gw.sk2.org [88.186.243.14]) (Authenticated sender: steve@sk2.org) by player759.ha.ovh.net (Postfix) with ESMTPSA id E920FA660146; Mon, 30 Sep 2019 07:41:12 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Mon, 30 Sep 2019 09:41:12 +0200 From: Stephen Kitt To: Song Liu Cc: "Gustavo A. R. Silva" , Alexei Starovoitov , Daniel Borkmann , Martin Lau , Yonghong Song , linux-doc@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH] bpf: use flexible array members, not zero-length In-Reply-To: References: <20190928144814.27002-1-steve@sk2.org> <02a551bc-7551-7c0e-0215-5ac8856b0512@embeddedor.com> Message-ID: X-Sender: steve@sk2.org User-Agent: Roundcube Webmail/1.3.10 X-Originating-IP: 88.186.243.14 X-Webmail-UserID: steve@sk2.org X-Ovh-Tracer-Id: 12799793094767889791 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedrgedugdduvdefucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddm Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Le 30/09/2019 08:07, Song Liu a écrit : >> On Sep 28, 2019, at 10:49 PM, Gustavo A. R. Silva >> wrote: >> I think you should preserve the tab here. > > Agreed. Indeed (and I thought I’d checked whitespace changes!). V2 upcoming with an improved Coccinelle script which preserves whitespace and fixes a couple of other issues which appear in other files (attributes, and structs defined alongside the field declaration). > Besides this: > > Acked-by: Song Liu Thanks! Regards, Stephen