From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 139A9C433F5 for ; Tue, 5 Apr 2022 19:53:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1389776AbiDEP0l (ORCPT ); Tue, 5 Apr 2022 11:26:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1380940AbiDEOQj (ORCPT ); Tue, 5 Apr 2022 10:16:39 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 25C8315D3B7 for ; Tue, 5 Apr 2022 06:00:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649163637; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=azvmiUh+/dFI8v+3SQr0ihCgP4dAaSj/8MnAViPhi+0=; b=ZfgePaINPfnjQU6JaGerlHqyxHRbAu1NvxFVB5vgISBqgj6EDbKAhTMggeXQUXoxvVClKN YiOzdQTnfRwxlAcJ2b7XT5C0CcFpCuEb0+XI70PTsEpqx0+7lZCSs6Zr915s/bRvf5qpPj xMIe4/zJEMcodIO6KEEkCAxUK1YYd+0= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-114-OXDdvfL1OYi7V8Dten1CRQ-1; Tue, 05 Apr 2022 09:00:28 -0400 X-MC-Unique: OXDdvfL1OYi7V8Dten1CRQ-1 Received: by mail-ej1-f71.google.com with SMTP id 13-20020a170906328d00b006982d0888a4so6286460ejw.9 for ; Tue, 05 Apr 2022 06:00:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:message-id:date:mime-version:user-agent:cc :subject:content-language:to:references:in-reply-to :content-transfer-encoding; bh=azvmiUh+/dFI8v+3SQr0ihCgP4dAaSj/8MnAViPhi+0=; b=pF1l2Yq7qFbBiQ6MjYSjowKMEIgEacOQRcnoH5APWMxhLBUAq27DbMUUz1eiOBgpzc KrWqqtInFZAy7tchNSNdzXSWaQWTRq9OTHp4qkKwfdlqcET9Ioaud1pavGVrMab5FMm2 O84TY80MLmIKRtFlDBKvJ4vSezi08osfhcmZqWtCB/wilPPrFaAjimt/0D0emvOydiwi KrEUj+ET52N/x4VHQNhlh4yWNp2I7I8J+T4PeuIkHYWcHa8HyDggf3pa5LHXAW9yBFwA Sp0zVwXzIkrmL2Aa6bqBF+2MtsAHoyzmxEW2r2cL8wq4XvOqivmcRwp8b91VG+Whivdy z89A== X-Gm-Message-State: AOAM530Yirv5ESy9MMC9hoJPzCO+5TJUVqONasSlljrVJk2kjo6BVtvw Tdd9Yk2FQDe+bT3Q7I0BXTM1daPP2R8j/qmjTPWHc7fudTNTaYc1eCKrSlgKb9fP3M0j6ACH4+u TY+3esJFvdEp7 X-Received: by 2002:a05:6402:51c6:b0:419:8269:f33d with SMTP id r6-20020a05640251c600b004198269f33dmr3433834edd.264.1649163626820; Tue, 05 Apr 2022 06:00:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz4dz3DTx2/UEbFiJXnLOy01NscM9Mvf8IaOKzmIFuOKHuprPdRu+9YHI0N77kS5wEuOM9Jfw== X-Received: by 2002:a05:6402:51c6:b0:419:8269:f33d with SMTP id r6-20020a05640251c600b004198269f33dmr3433807edd.264.1649163626569; Tue, 05 Apr 2022 06:00:26 -0700 (PDT) Received: from [192.168.2.20] (3-14-107-185.static.kviknet.dk. [185.107.14.3]) by smtp.gmail.com with ESMTPSA id o3-20020aa7c7c3000000b00410d407da2esm6329516eds.13.2022.04.05.06.00.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Apr 2022 06:00:26 -0700 (PDT) From: Jesper Dangaard Brouer X-Google-Original-From: Jesper Dangaard Brouer Message-ID: Date: Tue, 5 Apr 2022 15:00:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Cc: brouer@redhat.com, netdev@vger.kernel.org, maximmi@nvidia.com, alexandr.lobakin@intel.com Subject: Re: [PATCH bpf-next 02/10] xsk: diversify return codes in xsk_rcv_check() Content-Language: en-US To: Maciej Fijalkowski , bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net, magnus.karlsson@intel.com, bjorn@kernel.org References: <20220405110631.404427-1-maciej.fijalkowski@intel.com> <20220405110631.404427-3-maciej.fijalkowski@intel.com> In-Reply-To: <20220405110631.404427-3-maciej.fijalkowski@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On 05/04/2022 13.06, Maciej Fijalkowski wrote: > Inspired by patch that made xdp_do_redirect() return values for XSKMAP > more meaningful, return -ENXIO instead of -EINVAL for socket being > unbound in xsk_rcv_check() as this is the usual value that is returned > for such event. In turn, it is now possible to easily distinguish what > went wrong, which is a bit harder when for both cases checked, -EINVAL > was returned. I like this as it makes it easier to troubleshoot. Could you update the description to explain how to debug this easily. E.g. via this bpftrace one liner: bpftrace -e 'tracepoint:xdp:xdp_redirect* {@err[-args->err] = count();}' > Signed-off-by: Maciej Fijalkowski > --- Acked-by: Jesper Dangaard Brouer > net/xdp/xsk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/xdp/xsk.c b/net/xdp/xsk.c > index f75e121073e7..040c73345b7c 100644 > --- a/net/xdp/xsk.c > +++ b/net/xdp/xsk.c > @@ -217,7 +217,7 @@ static bool xsk_is_bound(struct xdp_sock *xs) > static int xsk_rcv_check(struct xdp_sock *xs, struct xdp_buff *xdp) > { > if (!xsk_is_bound(xs)) > - return -EINVAL; > + return -ENXIO; > > if (xs->dev != xdp->rxq->dev || xs->queue_id != xdp->rxq->queue_index) > return -EINVAL; >