From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69D1FC77B62 for ; Mon, 3 Apr 2023 11:11:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231859AbjDCLLO (ORCPT ); Mon, 3 Apr 2023 07:11:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232123AbjDCLLL (ORCPT ); Mon, 3 Apr 2023 07:11:11 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83C982D4A for ; Mon, 3 Apr 2023 04:10:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680520223; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2LyTXIwTIB/nVxYXSDDIz7jSdM+ZVkfbUtijN6RN/W0=; b=eQOzxIBmubDrJygysoibgT0Ehz51RvK/34tapLj2paIGkGtcgT8gWjchdCXaUA6TNkOO+5 INNgYdmAgzNLaVTGFgtxintov3Cxx176WTWNeBWDZJ0Kbpq9+mE4ueDJoGaKvzORhyzSRg MkU4A3PFDGA/qrwH5i1DWKXTQs0uJSc= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-134-HujMAXrVMIS5Y5mEEsQkJA-1; Mon, 03 Apr 2023 07:10:22 -0400 X-MC-Unique: HujMAXrVMIS5Y5mEEsQkJA-1 Received: by mail-qv1-f71.google.com with SMTP id w2-20020a0cc242000000b00583d8e55181so12870021qvh.23 for ; Mon, 03 Apr 2023 04:10:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680520222; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2LyTXIwTIB/nVxYXSDDIz7jSdM+ZVkfbUtijN6RN/W0=; b=hz2AIs8iq20goFbT1uRtd6auqmiqd6zjbKmg3w2sJpMWQwBB9pYXyKglzhzuSZIM8B Pj4WHluOydfr5sWyqjsEGD0ulPUifVczbvQm23t3hLOliWDHYM7XIBQV9t1BOz9si3Pm 4aWooBcc1UKAdzRIp/+sAsry9NrwBkANHI34QiQ2lhIFMpBGHpnp2yK8Zb8THhaehhSe evNCHVrYFRrroB7fkJYWXB+X5PaRopB6GmkK2dMUwqb0Oz5c89Y2G/mMyoa4fJ0iDZNW CvZCm5N4ZPlb+hrC32yUjOy3L6mk4V0hnjOJppNBQir6zRJ/4K6QyC7OKWZ59dLUesBJ NfYg== X-Gm-Message-State: AAQBX9eUllkIjqloGmURJHD6xBAcmQqVu/wa8uLWWz3Y2eGg/gP5EJmL rw9DR5ofjIIYpJbwjhmZDv4MvDO4mV3bfjJzoCFmLOtGbgG+E0OUqLHDB1b+H1Tx2EzhX86fwG2 ACdonixORaaSd X-Received: by 2002:a05:6214:20af:b0:5b7:fc3f:627c with SMTP id 15-20020a05621420af00b005b7fc3f627cmr56199445qvd.41.1680520222091; Mon, 03 Apr 2023 04:10:22 -0700 (PDT) X-Google-Smtp-Source: AKy350anlnRjskidVzUxw4lC24jdLIo1HJimHkPD2ABe7fU37aXmhofK7QF06gaCIs48vZzsoFlAZQ== X-Received: by 2002:a05:6214:20af:b0:5b7:fc3f:627c with SMTP id 15-20020a05621420af00b005b7fc3f627cmr56199409qvd.41.1680520221837; Mon, 03 Apr 2023 04:10:21 -0700 (PDT) Received: from sgarzare-redhat (host-82-57-51-130.retail.telecomitalia.it. [82.57.51.130]) by smtp.gmail.com with ESMTPSA id di15-20020ad458ef000000b005e13c17dcb8sm2536442qvb.79.2023.04.03.04.10.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Apr 2023 04:10:21 -0700 (PDT) Date: Mon, 3 Apr 2023 13:10:14 +0200 From: Stefano Garzarella To: John Fastabend Cc: Bobby Eshleman , Stefan Hajnoczi , "Michael S. Tsirkin" , Jason Wang , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrii Nakryiko , Mykola Lysenko , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Shuah Khan , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH net-next v4 0/3] Add support for sockmap to vsock. Message-ID: References: <20230327-vsock-sockmap-v4-0-c62b7cd92a85@bytedance.com> <6427838247d16_c503a2087e@john.notmuch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <6427838247d16_c503a2087e@john.notmuch> Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Fri, Mar 31, 2023 at 06:06:10PM -0700, John Fastabend wrote: >Bobby Eshleman wrote: >> We're testing usage of vsock as a way to redirect guest-local UDS >> requests to the host and this patch series greatly improves the >> performance of such a setup. >> >> Compared to copying packets via userspace, this improves throughput by >> 121% in basic testing. >> >> Tested as follows. >> >> Setup: guest unix dgram sender -> guest vsock redirector -> host vsock >> server >> Threads: 1 >> Payload: 64k >> No sockmap: >> - 76.3 MB/s >> - The guest vsock redirector was >> "socat VSOCK-CONNECT:2:1234 UNIX-RECV:/path/to/sock" >> Using sockmap (this patch): >> - 168.8 MB/s (+121%) >> - The guest redirector was a simple sockmap echo server, >> redirecting unix ingress to vsock 2:1234 egress. >> - Same sender and server programs >> >> *Note: these numbers are from RFC v1 >> >> Only the virtio transport has been tested. The loopback transport was >> used in writing bpf/selftests, but not thoroughly tested otherwise. >> >> This series requires the skb patch. > >Appears reasonable to me although I didn't review internals of all >the af_vsock stuff. I see it got merged great. Thanks for checking! > >One nit, I have a series coming shortly to pull the tests out of >the sockmap_listen and into a sockmap_vsock because I don't think they >belong in _listen but that is just a refactor. > LGTM! Thanks, Stefano