From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D32AEC433DF for ; Wed, 27 May 2020 07:25:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ABADB20C56 for ; Wed, 27 May 2020 07:25:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LnGhPbs0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729112AbgE0HZo (ORCPT ); Wed, 27 May 2020 03:25:44 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:32530 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728984AbgE0HZo (ORCPT ); Wed, 27 May 2020 03:25:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590564343; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3Mrfm+NbtjXlj6SJup9PtU2NprE7561iMdsmIlmqSE4=; b=LnGhPbs0jCpOa9gj3/WpDJI/ocJkqJeB2uLiOtL85FVS4/rGGS7doCTp/BYwsR2pjGbf0P qETgXCZyLl4pn/uIHWCjTrANR5leSxalPbUPZaN7kKPLSgW6rUyUckbdXoval2mVWH2aan lPlhGJAcl1VO9idFrrujXx5mm5xdCh0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-421-Gp7QDcHHONSqCPWslrtuBw-1; Wed, 27 May 2020 03:25:41 -0400 X-MC-Unique: Gp7QDcHHONSqCPWslrtuBw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4CB858014D7; Wed, 27 May 2020 07:25:40 +0000 (UTC) Received: from astarta.redhat.com (ovpn-114-49.ams2.redhat.com [10.36.114.49]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CBF0D5C1B0; Wed, 27 May 2020 07:25:37 +0000 (UTC) From: Yauheni Kaliuta To: Andrii Nakryiko Cc: bpf , Jiri Benc , Jiri Olsa , Andrii Nakryiko , Daniel Borkmann , Shuah Khan , "open list\:KERNEL SELFTEST FRAMEWORK" Subject: Re: [PATCH 0/8] selftests/bpf: installation and out of tree build fixes References: <20200522041310.233185-1-yauheni.kaliuta@redhat.com> Date: Wed, 27 May 2020 10:25:35 +0300 In-Reply-To: (Andrii Nakryiko's message of "Tue, 26 May 2020 22:04:35 -0700") Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Hi, Andrii! >>>>> On Tue, 26 May 2020 22:04:35 -0700, Andrii Nakryiko wrote: > On Tue, May 26, 2020 at 9:52 PM Yauheni Kaliuta > wrote: >> >> Hi, Andrii! >> >> >>>>> On Tue, 26 May 2020 15:32:10 -0700, Andrii Nakryiko wrote: >> >> > On Thu, May 21, 2020 at 11:41 PM Yauheni Kaliuta >> > wrote: >> >> >> >> >> >> Actually, a bit more needed :) >> >> > From the other kselftest thread, it seems like selftests are not >> > supporting builds out-of-tree. With that, wouldn't it be simpler to >> > build in tree and then just copy selftests/bpf directory to wherever >> > you need to run tests from? It would be simple and reliable. Given I >> > and probably everyone else never build and run tests out-of-tree, it's >> > just too easy to break this and you'll be constantly chasing some >> > non-obvious breakages... >> >> > Is there some problem with such approach? >> >> This is `make install` ;). > So patch #2, #5, and #7 is solving just `make install` problem?.. No, they are fixing OOT build problems. I should have probably split the series, oot and install fixes. > My point is that by building in tree and then just copying > everything under selftests/bpf directory to wherever you want > to "install" it would just work. And won't require > complicating already complicated Makefile. Any problem with > such approach? I understand. I see only wasting of space as a problem, but should check. >> >> I personally do not need OOT build, but since it's in the code, >> I'd prefer either fix it or remove it, otherwise it's >> misleading. But I have not got reply from kselftest. >> >> >> >> >> >>>>> On Fri, 22 May 2020 07:13:02 +0300, Yauheni Kaliuta wrote: >> >> >> >> > I had a look, here are some fixes. >> >> > Yauheni Kaliuta (8): >> >> > selftests/bpf: remove test_align from Makefile >> >> > selftests/bpf: build bench.o for any $(OUTPUT) >> >> > selftests/bpf: install btf .c files >> >> > selftests/bpf: fix object files installation >> >> > selftests/bpf: add output dir to include list >> >> > selftests/bpf: fix urandom_read installation >> >> > selftests/bpf: fix test.h placing for out of tree build >> >> > selftests/bpf: factor out MKDIR rule >> >> >> >> > tools/testing/selftests/bpf/Makefile | 77 ++++++++++++++++++++-------- >> >> > 1 file changed, 55 insertions(+), 22 deletions(-) >> >> >> >> > -- >> >> > 2.26.2 >> >> >> >> >> >> -- >> >> WBR, >> >> Yauheni Kaliuta >> >> >> >> >> -- >> WBR, >> Yauheni Kaliuta >> -- WBR, Yauheni Kaliuta