From: "Harley A.W. Lorenzo" <hl1998@protonmail.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-safety@lists.elisa.tech" <linux-safety@lists.elisa.tech>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"stern@rowland.harvard.edu" <stern@rowland.harvard.edu>
Subject: Re: [PATCH] usb: host: ehci-sched: avoid possible NULL dereference
Date: Mon, 05 Oct 2020 23:19:02 +0000 [thread overview]
Message-ID: <brWYeL8miTAikvEPYFNe2Kpe05OBtiD6yuS6jRg1VCX-lt7ANc1B2y7AM6ECEoG9AJwZP5_5qoGO7POvK0MtruvqG8q8kHbyHiOUIZ72Klk=@protonmail.com> (raw)
In-Reply-To: <20201005213149.12332-1-sudipm.mukherjee@gmail.com>
On Monday, October 5, 2020 5:31 PM, Sudip Mukherjee <sudipm.mukherjee@gmail.com> wrote:
> find_tt() can return NULL or the error value in ERR_PTR() and
> dereferencing the return value without checking for the error can
> lead to a possible dereference of NULL pointer or ERR_PTR().
Looks fine to me. There is in fact no checks of the return value
before a dereference here, and this solves that.
Reviewed-by: Harley A.W. Lorenzo <hl1998@protonmail.com
next prev parent reply other threads:[~2020-10-05 23:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-05 21:31 [PATCH] usb: host: ehci-sched: avoid possible NULL dereference Sudip Mukherjee
2020-10-05 23:19 ` Harley A.W. Lorenzo [this message]
2020-10-06 1:25 ` stern
2020-10-06 17:58 ` Alan Stern
2020-10-06 7:19 ` gregkh
2020-10-06 8:31 ` [linux-safety] " Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='brWYeL8miTAikvEPYFNe2Kpe05OBtiD6yuS6jRg1VCX-lt7ANc1B2y7AM6ECEoG9AJwZP5_5qoGO7POvK0MtruvqG8q8kHbyHiOUIZ72Klk=@protonmail.com' \
--to=hl1998@protonmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-safety@lists.elisa.tech \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.