From: Arnout Vandecappelle <arnout@mind.be>
To: Thomas De Schampheleire <patrickdepinguin@gmail.com>,
buildroot@buildroot.org
Cc: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>,
Giulio Benetti <giulio.benetti@benettiengineering.com>,
Romain Naour <romain.naour@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [Buildroot] [PATCH 2/2] toolchain/helpers.mk: gdbinit: set auto-load-safe-path before sysroot
Date: Tue, 21 Sep 2021 22:46:06 +0200 [thread overview]
Message-ID: <1d202363-484d-cc2a-818f-2b1b4fb7b358@mind.be> (raw)
In-Reply-To: <20210913072942.30109-2-patrickdepinguin@gmail.com>
On 13/09/2021 09:29, Thomas De Schampheleire wrote:
> From: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
>
> The gdbinit supplied by Buildroot does two things:
> A. specify the sysroot where gdb can find shared libraries
> B. mark the sysroot as a 'safe path' for its auto-load feature, to make sure
> that pretty printers for libstdc++.so are added automatically (see commit
> 6fb3216a80c64c08375429d89497eaeec5622150)
>
> When debugging a core file, and the gdbinit file is specified via '-x'
> rather than '-ix', then the order of these settings matters: If you first
> set the sysroot, then gdb will immediately start finding the shared
> libraries it needs for the core file, detect libstdc++ and its associated
> libstdc++-gdb.py file, then give a big warning about safe paths:
>
> warning: File ".../i686-buildroot-linux-gnu/sysroot/lib/libstdc++.so.6.0.24-gdb.py"
> auto-loading has been declined by your `auto-load safe-path' set
> to "$debugdir:$datadir/auto-load".
> To enable execution of this file add
> add-auto-load-safe-path .../i686-buildroot-linux-gnu/sysroot/lib/libstdc++.so.6.0.24-gdb.py
> line to your configuration file "/home/me/.gdbinit".
> To completely disable this security protection add
> set auto-load safe-path /
> line to your configuration file "/home/me/.gdbinit".
> For more information about this security protection see the
> "Auto-loading safe path" section in the GDB manual. E.g., run from the shell:
> info "(gdb)Auto-loading safe path"
>
> and the pretty printing code is not loaded. This is because the second
> line from the gdbinit file was not yet parsed at this point.
>
> By changing the order (first configuring the safe path, then setting the
> sysroot), this issue does not appear and everything is as expected.
>
> Note that when '-ix' were used instead of '-x' to pass the gdbinit file to
> gdb, then the order would not matter, because the entire gdbinit file would
> be parsed before considering the core file.
> However, even though the Buildroot manual now suggests '-ix', users may not
> have noticed this change and continue to use '-x'.
Whaa, excellent, not content with fixing a bug once, you fix it twice!
Applied to master, thanks. :-)
Regards,
Arnout
>
> Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
> ---
> toolchain/helpers.mk | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/toolchain/helpers.mk b/toolchain/helpers.mk
> index 1dfb52ac38..ef8e9a5f64 100644
> --- a/toolchain/helpers.mk
> +++ b/toolchain/helpers.mk
> @@ -481,8 +481,8 @@ check_toolchain_ssp = \
> #
> gen_gdbinit_file = \
> mkdir -p $(STAGING_DIR)/usr/share/buildroot/ ; \
> - echo "set sysroot $(STAGING_DIR)" > $(STAGING_DIR)/usr/share/buildroot/gdbinit ; \
> - echo "add-auto-load-safe-path $(STAGING_DIR)" >> $(STAGING_DIR)/usr/share/buildroot/gdbinit
> + echo "add-auto-load-safe-path $(STAGING_DIR)" > $(STAGING_DIR)/usr/share/buildroot/gdbinit ; \
> + echo "set sysroot $(STAGING_DIR)" >> $(STAGING_DIR)/usr/share/buildroot/gdbinit
>
> # Given a path, determine the relative prefix (../) needed to return to the
> # root level. Note that the last component is treated as a file component; use a
>
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-09-21 20:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 7:29 [Buildroot] [PATCH 1/2] docs/manual/using-buildroot-debugger: suggest '-ix' iso '-x' when loading gdbinit Thomas De Schampheleire
2021-09-13 7:29 ` [Buildroot] [PATCH 2/2] toolchain/helpers.mk: gdbinit: set auto-load-safe-path before sysroot Thomas De Schampheleire
2021-09-21 20:46 ` Arnout Vandecappelle [this message]
2021-09-22 9:10 ` Thomas De Schampheleire
2021-10-04 20:24 ` Peter Korsgaard
2021-09-21 20:43 ` [Buildroot] [PATCH 1/2] docs/manual/using-buildroot-debugger: suggest '-ix' iso '-x' when loading gdbinit Arnout Vandecappelle
2021-10-04 20:22 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d202363-484d-cc2a-818f-2b1b4fb7b358@mind.be \
--to=arnout@mind.be \
--cc=buildroot@buildroot.org \
--cc=giulio.benetti@benettiengineering.com \
--cc=patrickdepinguin@gmail.com \
--cc=romain.naour@gmail.com \
--cc=thomas.de_schampheleire@nokia.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).