From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/python-pysftp: add missing C++ dependency from paramiko
Date: Tue, 20 Jul 2021 12:08:28 +0200 [thread overview]
Message-ID: <20210720100828.421187-1-thomas.petazzoni@bootlin.com> (raw)
python-paramiko has a dependency on C++ support, which was added in
commit 2d7b73cf75daedd4a198a75546308fedae7c9467 in 2016.
When python-pysftp was added in commit
3b920487bad119abf5bfb10a237cedd3b5278c10 in 2020, this C++ dependency
was not propagated, even though python-pysftp selects python-paramiko.
This commit fixes this issue by propagating the dependency, which
fixes this warning:
WARNING: unmet direct dependencies detected for BR2_PACKAGE_PYTHON_PARAMIKO
Depends on [n]: (BR2_PACKAGE_PYTHON [=n] || BR2_PACKAGE_PYTHON3 [=y]) && BR2_PACKAGE_PYTHON3 [=y] && BR2_INSTALL_LIBSTDCPP [=n]
Selected by [y]:
- BR2_PACKAGE_PYTHON_PYSFTP [=y] && (BR2_PACKAGE_PYTHON [=n] || BR2_PACKAGE_PYTHON3 [=y]) && BR2_PACKAGE_PYTHON3 [=y]
That occurs with configuration with C++ disabled, but python-pysftp
enabled.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
package/python-pysftp/Config.in | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/package/python-pysftp/Config.in b/package/python-pysftp/Config.in
index de2d2df63d..5d5b731f33 100644
--- a/package/python-pysftp/Config.in
+++ b/package/python-pysftp/Config.in
@@ -1,8 +1,13 @@
config BR2_PACKAGE_PYTHON_PYSFTP
bool "python-pysftp"
depends on BR2_PACKAGE_PYTHON3 # python-paramiko -> python-bcrypt
+ depends on BR2_INSTALL_LIBSTDCPP # python-paramiko
select BR2_PACKAGE_PYTHON_PARAMIKO # runtime
help
A friendly face on SFTP.
https://bitbucket.org/dundeemt/pysftp
+
+comment "python-pysftp needs a toolchain w/ C++"
+ depends on BR2_PACKAGE_PYTHON3
+ depends on !BR2_INSTALL_LIBSTDCPP
--
2.31.1
next reply other threads:[~2021-07-20 10:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 10:08 Thomas Petazzoni [this message]
2021-07-25 13:37 ` [Buildroot] [PATCH] package/python-pysftp: add missing C++ dependency from paramiko Thomas Petazzoni
2021-08-05 10:06 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210720100828.421187-1-thomas.petazzoni@bootlin.com \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).