Re: [Buildroot] [PATCH v3 00/11] Support for Cargo and Go vendoring

From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: James Hilliard <james.hilliard1@gmail.com>,
	Christian Stewart <christian@paral.in>,
	Buildroot List <buildroot@buildroot.org>,
	Matt Weber <Matthew.Weber@rockwellcollins.com>,
	"Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Patrick Havelange <patrick.havelange@essensium.com>
Subject: Re: [Buildroot] [PATCH v3 00/11] Support for Cargo and Go vendoring
Date: Sat, 8 Jan 2022 23:39:56 +0100	[thread overview]
Message-ID: <20220108233956.3f145631@windsurf> (raw)
In-Reply-To: <20220106210000.397694-1-thomas.petazzoni@bootlin.com>

Hello,

On Thu,  6 Jan 2022 21:59:48 +0100
Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:

> Christian Stewart via buildroot (2):
>   package/embiggen-disk: new package
>   package/gocryptfs: new package
> 
> Patrick Havelange (3):
>   package/pkg-cargo.mk: introduce the cargo package infrastructure
>   docs/manual/cargo: document the cargo-package infrastructure
>   package/ripgrep: convert to cargo infrastructure
> 
> Thomas Petazzoni (6):
>   support/download/dl-wrapper: add concept of download post-processing
>   package/pkg-download.mk: add <pkg>_DOWNLOAD_POST_PROCESS variable
>   support/download/post-process-helpers: add helper function for post
>     process scripts
>   package/pkg-golang.mk: implement Go vendoring support
>   package/sentry-cli: re-add package
>   package/tinifier: new package

So, this series has been applied, with some additional tweaks based on
your feedback + review from Yann and Arnout.

Here are the things that have *not* yet been taken into account, and
left for future work:

 * We still use "cargo install" even though that causes rebuilds with
   some packages. Either we switch to a manual installation, or we
   "wait" for some better solution from cargo maintainers.

 * We don't use environment variables for everything, and some flags
   are passed through a cargo config file, which is not ideal.

 * We only support cargo/go packages that use .tar.gz tarballs, because
   the repacking with mk_tar_gz assumes .tar.gz is used.

These 3 limitations have been captured in the TODO list at
https://elinux.org/Buildroot#Core_Buildroot_infrastructure. Patches
welcome to implement these things of course, but we wanted to get the
initial infrastructure in place and merged, so that we can build on top
of it.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot