From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2] package/nfs-utils: improve local patch
Date: Thu, 11 Aug 2022 22:47:52 +0200 [thread overview]
Message-ID: <20220811224752.1a1e53b7@windsurf> (raw)
In-Reply-To: <20220810233824.714623-1-giulio.benetti@benettiengineering.com>
On Thu, 11 Aug 2022 01:38:24 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> As Thomas Petazzoni made me notice the actual local patch is not a good way
> at all to deal with pkg-config with Autotools. So let's rework the patch
It is recommended to avoid first person sentences in commit logs.
> according to his comment that represents the standard of Autotools
> pkg-config usage. This impacts host-nfs-utils too that is used to build
> nfs-utils and so libmount must be present in host. We do this by adding
> host-util-linux to HOST_NFS_UTILS_DEPENDENCIES since it is the libmount
> provider.
So, host-utils-linux is now only needed by host-nfs-utils because of
the new check in configure.ac, but nfsrahead is in fact not built for the host?
If it's the case, then the configure.ac change is wrong, and the mount
library of util-linux should only be checked using PKG_CHECK_MODULES()
when it is actually needed.
Another nfs-utils thing I noticed:
ifeq ($(BR2_PACKAGE_UTIL_LINUX_LIBBLKID),y)
NFS_UTILS_CONF_OPTS += --enable-uuid
else
NFS_UTILS_CONF_OPTS += --disable-uuid
endif
but BR2_PACKAGE_NFS_UTILS selects BR2_PACKAGE_UTIL_LINUX_LIBBLKID so
this conditional doesn't make much sense.
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-08-11 20:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 21:51 [Buildroot] [PATCH] package/nfs-utils: improve local patch Giulio Benetti
2022-08-10 23:38 ` [Buildroot] [PATCH v2] " Giulio Benetti
2022-08-11 20:16 ` Petr Vorel
2022-08-11 20:47 ` Thomas Petazzoni via buildroot [this message]
2022-09-19 22:47 ` [Buildroot] [PATCH] package/nfs-utils: handle pkg-config in the Autotools standard way for nfsrahead Giulio Benetti
2023-02-07 17:48 ` Thomas Petazzoni via buildroot
2022-09-19 22:50 ` [Buildroot] [PATCH v2] package/nfs-utils: improve local patch Giulio Benetti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220811224752.1a1e53b7@windsurf \
--to=buildroot@buildroot.org \
--cc=giulio.benetti@benettiengineering.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).