From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>
Cc: "Alvaro G . M" <alvaro.gamez@hazent.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/dcron: fix /etc/cron.d/system cron jobs
Date: Sat, 24 Sep 2022 10:30:36 +0200 [thread overview]
Message-ID: <20220924103036.6ba8ea92@windsurf> (raw)
In-Reply-To: <20220902222849.1098641-1-mario.haustein@hrz.tu-chemnitz.de>
Hello Mario,
Thanks for your patch. See below some questions/comments.
On Sat, 3 Sep 2022 00:28:49 +0200
Mario Haustein <mario.haustein@hrz.tu-chemnitz.de> wrote:
> Jobs with the syntax @hourly, @daily, ... were not executed since the
> recent version bump. This patch fixes the bug downstream.
Which "recent" version bump ?
The last commit on package/dcron/ in Builroot is from January 2021, I
wouldn't call it recent. It bumped from version 4.5 to
1ba33c3325df48de46263276a43ed76cf9d81518, while switching to
https://github.com/dubiousjim/dcron/ as the upstream location.
Is it this version bump that broke things?
> diff --git a/package/dcron/0002-system-crontab.patch b/package/dcron/0002-system-crontab.patch
> new file mode 100644
> index 0000000000..5573c68111
> --- /dev/null
> +++ b/package/dcron/0002-system-crontab.patch
> @@ -0,0 +1,23 @@
> +commit 1fd99b71b063b1573beaf9f6b801ec5be2fbe24f
> +Author: Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>
> +Date: Fri Sep 2 23:20:14 2022 +0200
> +
> + Make @hourly, @daily, ... work again
> +
> + closes #15
> +
> + Signed-off-by: Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>
Could you use "git format-patch" to generate this patch, and include in
it a reference to the upstream pull request
https://github.com/dubiousjim/dcron/pull/35.
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-09-24 8:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 22:28 [Buildroot] [PATCH 1/1] package/dcron: fix /etc/cron.d/system cron jobs Mario Haustein
2022-09-24 8:30 ` Thomas Petazzoni [this message]
2022-09-26 16:15 ` Mario Haustein
2022-09-26 16:08 ` [Buildroot] [PATCH v2] " Mario Haustein
2023-04-17 6:48 ` Yann E. MORIN
2023-04-23 10:37 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220924103036.6ba8ea92@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=alvaro.gamez@hazent.com \
--cc=buildroot@buildroot.org \
--cc=mario.haustein@hrz.tu-chemnitz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).