buildroot.busybox.net archive mirror
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/collectd: work around gcc bug 68485
@ 2022-09-24 23:08 Giulio Benetti
  2022-09-26 12:09 ` Thomas Petazzoni
  2022-10-12 15:44 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Giulio Benetti @ 2022-09-24 23:08 UTC (permalink / raw)
  To: buildroot; +Cc: Giulio Benetti, Asaf Kahlon

collectd is impacted by the microblaze-specific gcc bug #68485 [0].

As for all other impacted packages, force no optimisation when using a
toolchain riddled with that bug.

Fixes:
   http://autobuild.buildroot.net/results/6a8/6a87bbe17e6f606a97097800dc484a7b17bffa7d/

[0] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68485

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 package/collectd/collectd.mk | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/package/collectd/collectd.mk b/package/collectd/collectd.mk
index 5751757040..5510c265e8 100644
--- a/package/collectd/collectd.mk
+++ b/package/collectd/collectd.mk
@@ -27,6 +27,14 @@ COLLECTD_PLUGINS_DISABLE = \
 
 COLLECTD_CONF_ENV += LIBS="-lm"
 
+COLLECTD_CFLAGS = $(TARGET_CFLAGS)
+
+ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_68485),y)
+COLLECTD_CFLAGS += -O0
+endif
+
+COLLECTD_CONF_ENV += CFLAGS="$(COLLECTD_CFLAGS)"
+
 #
 # NOTE: There's also a third availible setting "intswap", which might
 # be needed on some old ARM hardware (see [2]), but is not being
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH] package/collectd: work around gcc bug 68485
  2022-09-24 23:08 [Buildroot] [PATCH] package/collectd: work around gcc bug 68485 Giulio Benetti
@ 2022-09-26 12:09 ` Thomas Petazzoni
  2022-10-12 15:44 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2022-09-26 12:09 UTC (permalink / raw)
  To: Giulio Benetti; +Cc: Asaf Kahlon, buildroot

On Sun, 25 Sep 2022 01:08:26 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> collectd is impacted by the microblaze-specific gcc bug #68485 [0].
> 
> As for all other impacted packages, force no optimisation when using a
> toolchain riddled with that bug.
> 
> Fixes:
>    http://autobuild.buildroot.net/results/6a8/6a87bbe17e6f606a97097800dc484a7b17bffa7d/
> 
> [0] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68485
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>  package/collectd/collectd.mk | 8 ++++++++
>  1 file changed, 8 insertions(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH] package/collectd: work around gcc bug 68485
  2022-09-24 23:08 [Buildroot] [PATCH] package/collectd: work around gcc bug 68485 Giulio Benetti
  2022-09-26 12:09 ` Thomas Petazzoni
@ 2022-10-12 15:44 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2022-10-12 15:44 UTC (permalink / raw)
  To: Giulio Benetti; +Cc: Asaf Kahlon, buildroot

>>>>> "Giulio" == Giulio Benetti <giulio.benetti@benettiengineering.com> writes:

 > collectd is impacted by the microblaze-specific gcc bug #68485 [0].
 > As for all other impacted packages, force no optimisation when using a
 > toolchain riddled with that bug.

 > Fixes:
 >    http://autobuild.buildroot.net/results/6a8/6a87bbe17e6f606a97097800dc484a7b17bffa7d/

 > [0] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68485

 > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

Committed to 2022.02.x and 2022.08.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-10-12 15:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-24 23:08 [Buildroot] [PATCH] package/collectd: work around gcc bug 68485 Giulio Benetti
2022-09-26 12:09 ` Thomas Petazzoni
2022-10-12 15:44 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).