From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Waldemar Brodkorb <wbx@openadk.org>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] configs/stm32f746g-disco: new defconfig
Date: Mon, 6 Feb 2023 23:02:03 +0100 [thread overview]
Message-ID: <20230206230203.70e2dbd8@windsurf> (raw)
In-Reply-To: <YywR+1YTnzQtkCrC@waldemar-brodkorb.de>
On Thu, 22 Sep 2022 09:42:51 +0200
Waldemar Brodkorb <wbx@openadk.org> wrote:
> Add support for ST Microsystems STM32F746G-DISCO board.
> See here for hardware details:
> https://www.st.com/en/evaluation-tools/32f746gdiscovery.html
>
> The LCD and Ethernet are _not_ yet supported by Linux upstream.
> The RAM is very limited, so the init script is stolen from the
> RISCV noMMU systems to support booting to a shell without crashing.
>
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
Sorry for the very very slow feedback. It mostly looks good of course,
but there are two things that bother me. One very small and easy to
address, another not so difficult, but I'm not entirely sure how to
address it.
See below.
> diff --git a/board/stmicroelectronics/stm32f746g-disco/rootfs_overlay/sbin/init b/board/stmicroelectronics/stm32f746g-disco/rootfs_overlay/sbin/init
> new file mode 100755
> index 0000000000..1285fd4420
> --- /dev/null
> +++ b/board/stmicroelectronics/stm32f746g-disco/rootfs_overlay/sbin/init
> @@ -0,0 +1,41 @@
> +#!/bin/sh
> +
> +# This script replaces the default busybox init process to avoid having that
> +# process staying alive and sleeping in the background, (uselessly) consuming
> +# precious memory.
[...]
What bothers me is that board/canaan/k210-soc/rootfs_overlay/sbin/init
is exactly the same script, so we're duplicating it. Can we do
something about it? I'm not exactly sure. A minimal "init" package for
noMMU systems maybe?
Also, do you really need this minimal init?
stm32f469_disco_sd_defconfig doesn't need it apparently.
> +BR2_TARGET_UBOOT=y
> +BR2_TARGET_UBOOT_CUSTOM_VERSION=y
> +BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2022.10-rc5"
Can we switch to a non-rc version?
Thanks a lot!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-02-06 22:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 7:42 [Buildroot] [PATCH] configs/stm32f746g-disco: new defconfig Waldemar Brodkorb
2023-02-06 22:02 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230206230203.70e2dbd8@windsurf \
--to=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=wbx@openadk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).