buildroot.busybox.net archive mirror
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/2] package/bluez5_utils: fix media control profile
@ 2023-03-16 13:53 Lang Daniel via buildroot
  2023-03-19 13:51 ` Thomas Petazzoni via buildroot
  0 siblings, 1 reply; 2+ messages in thread
From: Lang Daniel via buildroot @ 2023-03-16 13:53 UTC (permalink / raw)
  To: buildroot; +Cc: marcin

With bluez 5.66 (bumped in c6c79d6) the Media Control Profile (MCP), Basic
Audio Profile (BAP) and Volume Control Profile (VCP) where added.
All three are enabled by default.
MCP only works if AVRCP is enabled, as it requires player.c which is
otherwise not compiled.
Only enable all three new profiles when the audio plugin is selected.

Fixes:
 - http://autobuild.buildroot.net/results/d62/d6260a5acf766657f683d85fa1bdc27b7a43551e/

Signed-off-by: Daniel Lang <d.lang@abatec.at>
---
 package/bluez5_utils/bluez5_utils.mk | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)

diff --git a/package/bluez5_utils/bluez5_utils.mk b/package/bluez5_utils/bluez5_utils.mk
index 4059b34556..46ffda6019 100644
--- a/package/bluez5_utils/bluez5_utils.mk
+++ b/package/bluez5_utils/bluez5_utils.mk
@@ -64,9 +64,19 @@ endif
 
 # enable audio plugins (a2dp and avrcp)
 ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS_PLUGINS_AUDIO),y)
-BLUEZ5_UTILS_CONF_OPTS += --enable-a2dp --enable-avrcp
-else
-BLUEZ5_UTILS_CONF_OPTS += --disable-a2dp --disable-avrcp
+BLUEZ5_UTILS_CONF_OPTS += \
+	--enable-a2dp \
+	--enable-avrcp \
+	--enable-bap \
+	--enable-mcp \
+	--enable-vcp
+else
+BLUEZ5_UTILS_CONF_OPTS += \
+	--disable-a2dp \
+	--disable-avrcp \
+	--disable-bap \
+	--disable-mcp \
+	--disable-vcp
 endif
 
 # enable health plugin
-- 
2.25.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Buildroot] [PATCH 1/2] package/bluez5_utils: fix media control profile
  2023-03-16 13:53 [Buildroot] [PATCH 1/2] package/bluez5_utils: fix media control profile Lang Daniel via buildroot
@ 2023-03-19 13:51 ` Thomas Petazzoni via buildroot
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-03-19 13:51 UTC (permalink / raw)
  To: Lang Daniel via buildroot; +Cc: Lang Daniel, marcin

On Thu, 16 Mar 2023 13:53:04 +0000
Lang Daniel via buildroot <buildroot@buildroot.org> wrote:

> With bluez 5.66 (bumped in c6c79d6) the Media Control Profile (MCP), Basic
> Audio Profile (BAP) and Volume Control Profile (VCP) where added.
> All three are enabled by default.
> MCP only works if AVRCP is enabled, as it requires player.c which is
> otherwise not compiled.
> Only enable all three new profiles when the audio plugin is selected.
> 
> Fixes:
>  - http://autobuild.buildroot.net/results/d62/d6260a5acf766657f683d85fa1bdc27b7a43551e/
> 
> Signed-off-by: Daniel Lang <d.lang@abatec.at>
> ---
>  package/bluez5_utils/bluez5_utils.mk | 16 +++++++++++++---
>  1 file changed, 13 insertions(+), 3 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-03-19 13:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-16 13:53 [Buildroot] [PATCH 1/2] package/bluez5_utils: fix media control profile Lang Daniel via buildroot
2023-03-19 13:51 ` Thomas Petazzoni via buildroot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).