Re: [Buildroot] [autobuild.buildroot.net] Daily results for 2022-09-22

From: <yann.morin@orange.com>
To: Stafford Horne <shorne@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [autobuild.buildroot.net] Daily results for 2022-09-22
Date: Mon, 26 Sep 2022 17:04:45 +0200	[thread overview]
Message-ID: <32563_1664204687_6331BF8F_32563_34_1_20220926150445.GD3010@tl-lnx-nyma7486> (raw)
In-Reply-To: <YzG67nkiklO1Fzmp@oscomms1>

Staffod, All,

On 2022-09-26 14:45 +0000, Stafford Horne spake thusly:
> On Mon, Sep 26, 2022 at 11:12:18AM +0000, Stafford Horne wrote:
> > On Mon, Sep 26, 2022 at 11:51:13AM +0200, yann.morin@orange.com wrote:
> > > The more I look at it, the more it smells like a gcc issue. Thoughts?
[--SNIP--]
> > [...]  The --disable-tls may
> > be related to the issue.  The compiler may need to do something special to
> > disable generation of tls symbols when building with --disable-tls and OpenRISC is
> > not doing that.  I am guessing we are always generating the tls code sequences
> > and not obeying the --disable-tls flag when we should be.
> 
> OK, it seems this is the fix.  The --enable/disable-tls flag seems to only
> control a HAVE_AS_TLS macro in the gcc build.  OpenRISC was missing the below
> ifdef.  Adding it seems to fix the build for me.
> 
> Thanks Yann for the investigation that pointed right to the issue.
> 
> If you all can confirm this, I will post a gcc patch shortly and get it
> upstream.

Whaoo! :-)

I've spawned a build right now!

Regards,
Yann E. MORIN.

> --
> 
> diff --git a/gcc/config/or1k/or1k.cc b/gcc/config/or1k/or1k.cc
> index da2f59062ba..0ce7b234417 100644
> --- a/gcc/config/or1k/or1k.cc
> +++ b/gcc/config/or1k/or1k.cc
> @@ -2206,8 +2206,10 @@ or1k_output_mi_thunk (FILE *file, tree thunk_fndecl,
>  #undef  TARGET_LEGITIMATE_ADDRESS_P
>  #define TARGET_LEGITIMATE_ADDRESS_P or1k_legitimate_address_p
>  
> +#ifdef HAVE_AS_TLS
>  #undef  TARGET_HAVE_TLS
>  #define TARGET_HAVE_TLS true
> +#endif
>  
>  #undef  TARGET_HAVE_SPECULATION_SAFE_VALUE
>  #define TARGET_HAVE_SPECULATION_SAFE_VALUE speculation_safe_value_not_needed
> 

-- 
                                        ____________
.-----------------.--------------------:       _    :------------------.
|  Yann E. MORIN  | Real-Time Embedded |    __/ )   | /"\ ASCII RIBBON |
|                 | Software  Designer |  _/ - /'   | \ / CAMPAIGN     |
| +33 638.411.245 '--------------------: (_    `--, |  X  AGAINST      |
| yann.morin (at) orange.com           |_="    ,--' | / \ HTML MAIL    |
'--------------------------------------:______/_____:------------------'

_________________________________________________________________________________________________________________________

Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot