From: Arnout Vandecappelle <arnout@mind.be>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>, buildroot@buildroot.org
Cc: Kamel Bouhara <kamel.bouhara@gmail.com>
Subject: Re: [Buildroot] [PATCH 1/1] package/usbguard: needs at least a crypto backend
Date: Thu, 5 Aug 2021 18:50:36 +0200 [thread overview]
Message-ID: <45e174b0-8fe1-fc7c-83ce-58db5bba5a1e@mind.be> (raw)
In-Reply-To: <20210804100736.931756-1-fontaine.fabrice@gmail.com>
On 04/08/2021 12:07, Fabrice Fontaine wrote:
> Since its addition in commit fbff7d7289cc95db991184f890f4ca1fcf8a101e,
> usbguard needs a crypto backend otherwise the build will fail on:
>
> checking for sodium... no
> checking for libcrypto... no
> checking for powerpc-buildroot-linux-uclibc-libgcrypt-config... no
> checking for libgcrypt-config... no
> checking for LIBGCRYPT - version >= 1.5.0... no
> configure: error: The selected crypto backend library is not available.
>
> So select sodium as the default crypto backend as this is the default
> choice in configure.ac.
>
> Fixes:
> - http://autobuild.buildroot.org/results/fb9865e2c65ea1dd9a657e1181a6c8c49481fda7
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Applied to master, thanks.
Regards,
Arnout
> ---
> package/usbguard/Config.in | 1 +
> package/usbguard/usbguard.mk | 14 +++++---------
> 2 files changed, 6 insertions(+), 9 deletions(-)
>
> diff --git a/package/usbguard/Config.in b/package/usbguard/Config.in
> index 58ee5c4b25..41f19dc1a0 100644
> --- a/package/usbguard/Config.in
> +++ b/package/usbguard/Config.in
> @@ -8,6 +8,7 @@ config BR2_PACKAGE_USBGUARD
> depends on !BR2_TOOLCHAIN_USES_MUSL
> select BR2_PACKAGE_PROTOBUF
> select BR2_PACKAGE_LIBQB
> + select BR2_PACKAGE_LIBSODIUM if !BR2_PACKAGE_LIBGCRYPT && !BR2_PACKAGE_LIBOPENSSL
> help
> The USBGuard software framework
>
> diff --git a/package/usbguard/usbguard.mk b/package/usbguard/usbguard.mk
> index 1518f92fc5..a0d1c8446f 100644
> --- a/package/usbguard/usbguard.mk
> +++ b/package/usbguard/usbguard.mk
> @@ -18,23 +18,19 @@ USBGUARD_CONF_OPTS = \
>
> USBGUARD_DEPENDENCIES += libqb protobuf
>
> -ifeq ($(BR2_PACKAGE_LIBOPENSSL),y)
> +ifeq ($(BR2_PACKAGE_LIBSODIUM),y)
> +USBGUARD_CONF_OPTS += --with-crypto-library=sodium
> +USBGUARD_DEPENDENCIES += libsodium
> +else ifeq ($(BR2_PACKAGE_LIBOPENSSL),y)
> USBGUARD_CONF_OPTS += --with-crypto-library=openssl
> USBGUARD_DEPENDENCIES += libopenssl
> -endif
> -
> -ifeq ($(BR2_PACKAGE_LIBGCRYPT),y)
> +else ifeq ($(BR2_PACKAGE_LIBGCRYPT),y)
> USBGUARD_CONF_ENV += \
> ac_cv_path_LIBGCRYPT_CONFIG=$(STAGING_DIR)/usr/bin/libgcrypt-config
> USBGUARD_CONF_OPTS += --with-crypto-library=gcrypt
> USBGUARD_DEPENDENCIES += libgcrypt
> endif
>
> -ifeq ($(BR2_PACKAGE_LIBSODIUM),y)
> -USBGUARD_CONF_OPTS += --with-crypto-library=sodium
> -USBGUARD_DEPENDENCIES += libsodium
> -endif
> -
> ifeq ($(BR2_PACKAGE_SYSTEMD),y)
> USBGUARD_CONF_OPTS += --enable-systemd
> USBGUARD_DEPENDENCIES += systemd
>
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
prev parent reply other threads:[~2021-08-05 16:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 10:07 [Buildroot] [PATCH 1/1] package/usbguard: needs at least a crypto backend Fabrice Fontaine
2021-08-05 16:50 ` Arnout Vandecappelle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45e174b0-8fe1-fc7c-83ce-58db5bba5a1e@mind.be \
--to=arnout@mind.be \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=kamel.bouhara@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).