From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/4 v5] utils/test-pkg: remove configurations that are skipped
Date: Mon, 28 Jun 2021 22:15:13 +0200 [thread overview]
Message-ID: <5734b04e93f6ce2212a81963d8a0e79500f942c3.1624911306.git.yann.morin.1998@free.fr> (raw)
In-Reply-To: <cover.1624911306.git.yann.morin.1998@free.fr>
When the config fragment provided by the user is not usable with a
specific toolchain configuration, the resulting .config file was kept
around.
In a follow up commit, we'll need to know, from outside test-pkg, if a
specific configuration was indeed usable or not.
So, unless if the user actually requested to keep the build directories,
remove the .config file when it contains a configration that would be
skipped.
Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Cc: Romain Naour <romain.naour@gmail.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
v5: new patch
---
utils/test-pkg | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/utils/test-pkg b/utils/test-pkg
index a317d8c17a..54c6c5e8fe 100755
--- a/utils/test-pkg
+++ b/utils/test-pkg
@@ -161,6 +161,10 @@ build_one() {
# done in the same locale.
comm -23 <(sort "${cfg}") <(sort "${dir}/.config") >"${dir}/missing.config"
if [ -s "${dir}/missing.config" ]; then
+ if [ ${keep} -ne 1 ]; then
+ # Invalid configuration, drop it
+ rm -f "${dir}/.config"
+ fi
return 1
fi
# Remove file, it's empty anyway.
--
2.25.1
next prev parent reply other threads:[~2021-06-28 20:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 20:15 [Buildroot] [PATCH 0/4 v5] gitlab-ci: allow running test-pkg (branch yem/test-pkg-in-gitlab-ci) Yann E. MORIN
2021-06-28 20:15 ` [Buildroot] [PATCH 1/4 v5] support/misc/gitlab-ci.yml.in: templatise the make command Yann E. MORIN
2021-06-28 20:20 ` Thomas Petazzoni
2021-08-05 20:47 ` Arnout Vandecappelle
2021-06-28 20:15 ` Yann E. MORIN [this message]
2021-06-28 20:15 ` [Buildroot] [PATCH 3/4 v5] utils/test-pkg: add mode to only prepare .config files Yann E. MORIN
2021-08-05 20:45 ` Arnout Vandecappelle
2021-08-21 13:38 ` Romain Naour
2021-08-21 16:27 ` Yann E. MORIN
2021-06-28 20:15 ` [Buildroot] [PATCH 4/4 v5] utils/test-pkg: add gitlab-ci support Yann E. MORIN
2021-07-13 11:29 ` Yegor Yefremov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5734b04e93f6ce2212a81963d8a0e79500f942c3.1624911306.git.yann.morin.1998@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).