buildroot.busybox.net archive mirror
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/cegui: disable OpenGLES renderer
@ 2021-08-03 14:36 Bartosz Bilas
  2021-08-04 20:49 ` Arnout Vandecappelle
  0 siblings, 1 reply; 4+ messages in thread
From: Bartosz Bilas @ 2021-08-03 14:36 UTC (permalink / raw)
  To: buildroot; +Cc: Bartosz Bilas

Support of OpenGLES generates tons of autobuilders failures
so let's disable it till upstream finds a solution for that.

Fixes:
 http://autobuild.buildroot.net/results/41d/41d10c09472fbb8481a72c4f8bed789bb15bb3c2//
 http://autobuild.buildroot.net/results/9a8/9a8122b4d3d0aa9d71cdf8d21359411b130741f8//
 http://autobuild.buildroot.net/results/7e5/7e5dd79b48abde09bf4633b196579da5561f9fa1//

and many more...

Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>
---
 package/cegui/cegui.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/cegui/cegui.mk b/package/cegui/cegui.mk
index 127d3b0fad..2e56322374 100644
--- a/package/cegui/cegui.mk
+++ b/package/cegui/cegui.mk
@@ -13,6 +13,7 @@ CEGUI_CONF_OPTS = \
 	-DCEGUI_HAS_MINIZIP_RESOURCE_PROVIDER=OFF \
 	-DCEGUI_BUILD_RENDERER_IRRLICHT=OFF \
 	-DCEGUI_BUILD_RENDERER_OGRE=OFF \
+	-DCEGUI_BUILD_RENDERER_OPENGLES=OFF \
 	-DCEGUI_BUILD_XMLPARSER_XERCES=OFF \
 	-DCEGUI_USE_FRIBIDI=OFF \
 	-DCEGUI_SAMPLES_ENABLED=OFF \
-- 
2.32.0

_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH] package/cegui: disable OpenGLES renderer
  2021-08-03 14:36 [Buildroot] [PATCH] package/cegui: disable OpenGLES renderer Bartosz Bilas
@ 2021-08-04 20:49 ` Arnout Vandecappelle
  2021-08-05  7:38   ` Bartosz Biłas
  0 siblings, 1 reply; 4+ messages in thread
From: Arnout Vandecappelle @ 2021-08-04 20:49 UTC (permalink / raw)
  To: Bartosz Bilas, buildroot



On 03/08/2021 16:36, Bartosz Bilas wrote:
> Support of OpenGLES generates tons of autobuilders failures
> so let's disable it till upstream finds a solution for that.
> 
> Fixes:
>  http://autobuild.buildroot.net/results/41d/41d10c09472fbb8481a72c4f8bed789bb15bb3c2//
>  http://autobuild.buildroot.net/results/9a8/9a8122b4d3d0aa9d71cdf8d21359411b130741f8//
>  http://autobuild.buildroot.net/results/7e5/7e5dd79b48abde09bf4633b196579da5561f9fa1//
> 
> and many more...
> 
> Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>

 Applied to master, thanks.

 However, I wonder, if opengles is turned off, is the
$(if $(BR2_PACKAGE_HAS_LIBGLES),libgles) still relevant?

 Regards,
 Arnout

> ---
>  package/cegui/cegui.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/cegui/cegui.mk b/package/cegui/cegui.mk
> index 127d3b0fad..2e56322374 100644
> --- a/package/cegui/cegui.mk
> +++ b/package/cegui/cegui.mk
> @@ -13,6 +13,7 @@ CEGUI_CONF_OPTS = \
>  	-DCEGUI_HAS_MINIZIP_RESOURCE_PROVIDER=OFF \
>  	-DCEGUI_BUILD_RENDERER_IRRLICHT=OFF \
>  	-DCEGUI_BUILD_RENDERER_OGRE=OFF \
> +	-DCEGUI_BUILD_RENDERER_OPENGLES=OFF \
>  	-DCEGUI_BUILD_XMLPARSER_XERCES=OFF \
>  	-DCEGUI_USE_FRIBIDI=OFF \
>  	-DCEGUI_SAMPLES_ENABLED=OFF \
> 
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH] package/cegui: disable OpenGLES renderer
  2021-08-04 20:49 ` Arnout Vandecappelle
@ 2021-08-05  7:38   ` Bartosz Biłas
  2021-08-05 12:08     ` Arnout Vandecappelle
  0 siblings, 1 reply; 4+ messages in thread
From: Bartosz Biłas @ 2021-08-05  7:38 UTC (permalink / raw)
  To: Arnout Vandecappelle; +Cc: buildroot

Hello Arnout,

On 8/4/21 10:49 PM, Arnout Vandecappelle wrote:
>
> On 03/08/2021 16:36, Bartosz Bilas wrote:
>> Support of OpenGLES generates tons of autobuilders failures
>> so let's disable it till upstream finds a solution for that.
>>
>> Fixes:
>>   http://autobuild.buildroot.net/results/41d/41d10c09472fbb8481a72c4f8bed789bb15bb3c2//
>>   http://autobuild.buildroot.net/results/9a8/9a8122b4d3d0aa9d71cdf8d21359411b130741f8//
>>   http://autobuild.buildroot.net/results/7e5/7e5dd79b48abde09bf4633b196579da5561f9fa1//
>>
>> and many more...
>>
>> Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>
>   Applied to master, thanks.
>
>   However, I wonder, if opengles is turned off, is the
> $(if $(BR2_PACKAGE_HAS_LIBGLES),libgles) still relevant?

Ouch, I've completely forgotten about this line. I'm gonna send a patch 
that removes it too.

Best
Bartek
>
>   Regards,
>   Arnout
>
>> ---
>>   package/cegui/cegui.mk | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/package/cegui/cegui.mk b/package/cegui/cegui.mk
>> index 127d3b0fad..2e56322374 100644
>> --- a/package/cegui/cegui.mk
>> +++ b/package/cegui/cegui.mk
>> @@ -13,6 +13,7 @@ CEGUI_CONF_OPTS = \
>>   	-DCEGUI_HAS_MINIZIP_RESOURCE_PROVIDER=OFF \
>>   	-DCEGUI_BUILD_RENDERER_IRRLICHT=OFF \
>>   	-DCEGUI_BUILD_RENDERER_OGRE=OFF \
>> +	-DCEGUI_BUILD_RENDERER_OPENGLES=OFF \
>>   	-DCEGUI_BUILD_XMLPARSER_XERCES=OFF \
>>   	-DCEGUI_USE_FRIBIDI=OFF \
>>   	-DCEGUI_SAMPLES_ENABLED=OFF \
>>
-- 

_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH] package/cegui: disable OpenGLES renderer
  2021-08-05  7:38   ` Bartosz Biłas
@ 2021-08-05 12:08     ` Arnout Vandecappelle
  0 siblings, 0 replies; 4+ messages in thread
From: Arnout Vandecappelle @ 2021-08-05 12:08 UTC (permalink / raw)
  To: Bartosz Biłas; +Cc: buildroot



On 05/08/2021 09:38, Bartosz Biłas wrote:
> Hello Arnout,
> 
> On 8/4/21 10:49 PM, Arnout Vandecappelle wrote:
>>
>> On 03/08/2021 16:36, Bartosz Bilas wrote:
>>> Support of OpenGLES generates tons of autobuilders failures
>>> so let's disable it till upstream finds a solution for that.
>>>
>>> Fixes:
>>>  
>>> http://autobuild.buildroot.net/results/41d/41d10c09472fbb8481a72c4f8bed789bb15bb3c2//
>>>
>>>  
>>> http://autobuild.buildroot.net/results/9a8/9a8122b4d3d0aa9d71cdf8d21359411b130741f8//
>>>
>>>  
>>> http://autobuild.buildroot.net/results/7e5/7e5dd79b48abde09bf4633b196579da5561f9fa1//
>>>
>>>
>>> and many more...
>>>
>>> Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>
>>   Applied to master, thanks.
>>
>>   However, I wonder, if opengles is turned off, is the
>> $(if $(BR2_PACKAGE_HAS_LIBGLES),libgles) still relevant?
> 
> Ouch, I've completely forgotten about this line. I'm gonna send a patch that
> removes it too.

 To be sure that it's really not needed, you should:

- do a build of cegui without any libgles provider;
- save the build results somewhere;
- enable a libgles provider and build it;
- make cegui-dirclean cegui

If the second build result is different from the first (i.e, significantly
larger), the dependency can't be removed.


 Regards,
 Arnout

> 
> Best
> Bartek
>>
>>   Regards,
>>   Arnout
>>
>>> ---
>>>   package/cegui/cegui.mk | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/package/cegui/cegui.mk b/package/cegui/cegui.mk
>>> index 127d3b0fad..2e56322374 100644
>>> --- a/package/cegui/cegui.mk
>>> +++ b/package/cegui/cegui.mk
>>> @@ -13,6 +13,7 @@ CEGUI_CONF_OPTS = \
>>>       -DCEGUI_HAS_MINIZIP_RESOURCE_PROVIDER=OFF \
>>>       -DCEGUI_BUILD_RENDERER_IRRLICHT=OFF \
>>>       -DCEGUI_BUILD_RENDERER_OGRE=OFF \
>>> +    -DCEGUI_BUILD_RENDERER_OPENGLES=OFF \
>>>       -DCEGUI_BUILD_XMLPARSER_XERCES=OFF \
>>>       -DCEGUI_USE_FRIBIDI=OFF \
>>>       -DCEGUI_SAMPLES_ENABLED=OFF \
>>>
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-08-05 12:08 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-03 14:36 [Buildroot] [PATCH] package/cegui: disable OpenGLES renderer Bartosz Bilas
2021-08-04 20:49 ` Arnout Vandecappelle
2021-08-05  7:38   ` Bartosz Biłas
2021-08-05 12:08     ` Arnout Vandecappelle

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).